8293989: [JVMCI] re-use cleared oop handles

[dougxc]

It's possible for a libgraal isolate to live long enough that JVMCIRuntime::__oop_handles grows so much that it overflows when trying to expand. This results in a VM crash something like:

# There is insufficient memory for the Java Runtime Environment to continue.
# Native memory allocation (malloc) failed to allocate 18446744056529682432 bytes for AllocateHeap

...

V [libjvm.so+0xe1f441] VMError::report_and_die(int, char const*, char const*, __va_list_tag*, Thread*, unsigned char*, void*, void*, char const*, int, unsigned long)+0x1a1
V [libjvm.so+0xe2006d] VMError::report_and_die(Thread*, char const*, int, unsigned long, VMErrorType, char const*, __va_list_tag*)+0x2d
V [libjvm.so+0x5d8ed3] report_vm_out_of_memory(char const*, int, unsigned long, VMErrorType, char const*, ...)+0xc3
V [libjvm.so+0x39f7c2] AllocateHeap(unsigned long, MEMFLAGS, AllocFailStrategy::AllocFailEnum)+0x92
V [libjvm.so+0x8303f2] GrowableArrayWithAllocator<_jobject*, GrowableArray<_jobject*> >::grow(int)+0x112
V [libjvm.so+0x995385] JVMCIRuntime::make_global(Handle const&)+0x105

The solution implemented in this PR is to clear and re-use entries in JVMCIRuntime::__oop_handles.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293989: [JVMCI] re-use cleared oop handles

Reviewers

• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10337/head:pull/10337
$ git checkout pull/10337

Update a local copy of the PR:
$ git checkout pull/10337
$ git pull https://git.openjdk.org/jdk pull/10337/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10337

View PR using the GUI difftool:
$ git pr show -t 10337

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10337.diff

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (963fbefe)

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293989: [JVMCI] re-use cleared oop handles

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 6e23b43: 8293502: (fc) FileChannel::transfer methods fail to copy /proc files on Linux
• 1f9ff41: 8292297: Fix up loading of override java.security properties file
• 64b96e5: 8293811: Provide a reason for PassFailJFrame.forceFail
• f91762f: 8293965: Code signing warnings after JDK-8293550
• 8082c24: 8054572: [macosx] JComboBox paints the border incorrectly
• b920d29: 8271328: User is able to choose the color after disabling the color chooser.
• 5725a93: 8293879: Remove unnecessary castings in jdk.hotspot.agent
• ab7f58a: 6286501: JTabbedPane throws NPE from its stateChanged listener in particular case
• d41f69f: 8293849: PrintIdealPhase in compiler directives file is ignored when used with other compile commands
• 471e2f1: 8292088: C2: assert(is_OuterStripMinedLoop()) failed: invalid node class: IfTrue
• ... and 1 more: https://git.openjdk.org/jdk/compare/36c9034ff1274f37969550a3f9239f1bb16a0b25...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dougxc]

Thanks for the review Tom.

[dougxc]

/integrate

[openjdk]

Going to push as commit fe541f0.
Since your change was applied there have been 14 commits pushed to the master branch:

• 0fa7d9e: 8278863: Add method ClassDesc::ofInternalName
• 4020ed5: 8293210: G1: Remove redundant check in G1FreeHumongousRegionClosure
• 8ff2c26: 8293942: [JVMCI] data section entries must be 4-byte aligned on AArch64
• 6e23b43: 8293502: (fc) FileChannel::transfer methods fail to copy /proc files on Linux
• 1f9ff41: 8292297: Fix up loading of override java.security properties file
• 64b96e5: 8293811: Provide a reason for PassFailJFrame.forceFail
• f91762f: 8293965: Code signing warnings after JDK-8293550
• 8082c24: 8054572: [macosx] JComboBox paints the border incorrectly
• b920d29: 8271328: User is able to choose the color after disabling the color chooser.
• 5725a93: 8293879: Remove unnecessary castings in jdk.hotspot.agent
• ... and 4 more: https://git.openjdk.org/jdk/compare/36c9034ff1274f37969550a3f9239f1bb16a0b25...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit fe541f0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.