8302121: Parallel: Remove unused arg in PSCardTable::inline_write_ref_field_gc#12485
8302121: Parallel: Remove unused arg in PSCardTable::inline_write_ref_field_gc#12485albertnetymk wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back ayang! A progress list of the required criteria for merging this PR into |
|
@albertnetymk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
tschatzl
left a comment
There was a problem hiding this comment.
Lgtm and trivial. Ship it!
Note that very likely originally this parameter has been added for consistency with other collectors, but that should not concern parallel gc.
|
@albertnetymk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Thanks for the review. /integrate |
|
Going to push as commit d401982.
Your commit was automatically rebased without conflicts. |
|
@albertnetymk Pushed as commit d401982. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Trivial removing dead code.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12485/head:pull/12485$ git checkout pull/12485Update a local copy of the PR:
$ git checkout pull/12485$ git pull https://git.openjdk.org/jdk pull/12485/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12485View PR using the GUI difftool:
$ git pr show -t 12485Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12485.diff