8308986: Disable svc tests failing with virtual thread factory #14193

lmesnik · 2023-05-27T20:21:46Z

Disable test
java/util/concurrent/locks/Lock/OOMEInAQS.java
Test provokes OOME and might catch it in an unexpected location. It looks like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. However, generally the OOME might be thrown mount/umount or in unparker thread. There are no plans to fix such tests to be able to pass with virtual threads now.

Also, disable
mTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t001/TestDescription.java
vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t002/TestDescription.java
because of https://bugs.openjdk.org/browse/JDK-8308985

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8308986: Disable svc tests failing with virtual thread factory

Reviewers

David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 5ed56e68
Daniel D. Daugherty (@dcubed-ojdk - Reviewer) ⚠️ Review applies to 2c068101
Serguei Spitsyn (@sspitsyn - Reviewer) ⚠️ Review applies to 5ed56e68

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14193/head:pull/14193
$ git checkout pull/14193

Update a local copy of the PR:
$ git checkout pull/14193
$ git pull https://git.openjdk.org/jdk.git pull/14193/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14193

View PR using the GUI difftool:
$ git pr show -t 14193

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14193.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-05-27T20:22:55Z

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-05-27T20:24:35Z

@lmesnik To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

build
client
compiler
core-libs
graal
hotspot
hotspot-compiler
hotspot-gc
hotspot-jfr
hotspot-runtime
i18n
ide-support
javadoc
jdk
jmx
kulla
net
nio
security
serviceability
shenandoah

lmesnik · 2023-05-27T20:43:55Z

/cc serviceability

openjdk · 2023-05-27T20:44:42Z

@lmesnik
The serviceability label was successfully added.

mlbridge · 2023-05-27T20:49:12Z

Webrevs

AlanBateman · 2023-05-28T05:47:32Z

test/jdk/ProblemList-Virtual.txt

@@ -72,6 +72,7 @@ java/lang/Thread/UncaughtExceptionsTest.java 0000000 generic-all
 java/lang/Thread/virtual/GetStackTraceWhenRunnable.java 0000000 generic-all
 java/lang/invoke/condy/CondyNestedResolutionTest.java 0000000 generic-all
 java/lang/ref/OOMEInReferenceHandler.java 0000000 generic-all
+java/util/concurrent/locks/Lock/OOMEInAQS.java 0000000 generic-all


I read the comment a bit further up to see where it explains why this section uses "0000000" for the JBS issue. There's a few typos in the text, e.g. "with with" and "test migth". It might be useful to make that text a bit clearer as I'm sure there will be questions on why there aren't JBS issues for tests excluded from running this mode.

dholmes-ora

Hotspot changes are good.

JDK side seems okay if this is how we are permanently excluding tests from running with virtual threads. Though as Alan states the comments need a little work.

Thanks.

openjdk · 2023-05-29T04:56:00Z

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308986: Disable svc tests failing with virtual thread factory

Reviewed-by: dholmes, dcubed, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

1e6770f: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM
cb40db0: 8309134: Augment test/langtools/tools/javac/versions/Versions.java for JDK 21 language changes
de7fd1c: 8307944: ClassFileDumper should only load java.nio.file.Path if enabled
7891de3: 8297885: misc sun/security/pkcs11 tests timed out
323d6ce: 8308960: Decouple internal Version and OperatingSystem classes
1b8e6bf: 8308987: Update java.lang.Class to use javadoc snippets
04b0e78: 8307648: java/net/httpclient/ExpectContinueTest.java timed out
6b90b05: 8297878: KEM: Implementation
21af8ba: 8290499: new File(parent, "/") breaks normalization – creates File with slash at the end
804f198: 8308992: New test TestHFA fails with zero
... and 20 more: https://git.openjdk.org/jdk/compare/ca54f4e007ab0f13bec9aaf995d34c0ab3ba6452...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

sspitsyn · 2023-05-30T19:51:04Z

test/hotspot/jtreg/ProblemList-Virtual.txt

@@ -31,6 +31,8 @@ serviceability/dcmd/thread/PrintConcurrentLocksTest.java 8308033 generic-all
 serviceability/dcmd/thread/PrintTest.java 8308033 generic-all
 serviceability/dcmd/thread/ThreadDumpToFileTest.java 8308033 generic-all
 serviceability/tmtools/jstack/DaemonThreadTest.java 8308033 generic-all
+vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t001/TestDescription.java 8308985 generic-all
+vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t002/TestDescription.java 8308985 generic-all


I've closed the 8308985 as a dup of:
8308978 regression with a deadlock involving FollowReferences
Should the 8308985 be replaced with the 8308978?
There is already a tested fix for 8308978.
Alex is going to post a PR today or tomorrow.
Do we still want to problem-list these two tests?

Please switch from 8308985 to 8308978. I've also changed this bug
into a sub-task of 8308978 and bumped the priorities of both bugs
to P2. Regressions start at P2 and ProblemListing match the priority
of their parent bug.

dcubed-ojdk · 2023-05-30T19:58:09Z

Reducing noise in the CI is always good. Especially since it takes
ProblemListings and fixes a non-trivial amount of time to make it
to the upper tiers...

dcubed-ojdk · 2023-05-30T20:03:57Z

test/hotspot/jtreg/ProblemList-Virtual.txt

@@ -31,6 +31,8 @@ serviceability/dcmd/thread/PrintConcurrentLocksTest.java 8308033 generic-all
 serviceability/dcmd/thread/PrintTest.java 8308033 generic-all
 serviceability/dcmd/thread/ThreadDumpToFileTest.java 8308033 generic-all
 serviceability/tmtools/jstack/DaemonThreadTest.java 8308033 generic-all
+vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t001/TestDescription.java 8308985 generic-all
+vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t002/TestDescription.java 8308985 generic-all


Please switch from 8308985 to 8308978. I've also changed this bug
into a sub-task of 8308978 and bumped the priorities of both bugs
to P2. Regressions start at P2 and ProblemListing match the priority
of their parent bug.

sspitsyn · 2023-05-30T20:04:13Z

Reducing noise in the CI is always good. Especially since it takes
Okay. We should not forget to unproblem-list the two test.

sspitsyn

Looks good modulo my comment.
It is up to you to decide what bug number to use in the Hotspot problem list.
Also, there are more failing tests because of this issue. For instance:

  vmTestbase/nsk/jdi/VirtualMachine/instanceCounts/instancecounts001/instancecounts001.java
  vmTestbase/nsk/jdi/ReferenceType/instances/instances001/instances001.java
  vmTestbase/nsk/jdi/stress/serial/mixed002/TestDescription.java
  vmTestbase/nsk/jdi/stress/serial/heapwalking002/TestDescription.java

Thanks,
Serguei

lmesnik · 2023-05-30T20:30:01Z

I've excluded more tests, changed bugid and updated comments.

dcubed-ojdk · 2023-05-30T20:47:28Z

I've been trying to figure out what java/util/concurrent/locks/Lock/OOMEInAQS.java
has to do with the deadlock bug, but I think I just got confused by using a single
bug ID to do the ProblemListings for more than one problem...

dcubed-ojdk

Thumbs up. Quite a few tests now for 8308978.

dcubed-ojdk · 2023-05-30T20:48:22Z

test/jdk/ProblemList-Virtual.txt

 ## There is no goal to run all test with virtual test thread factory.
-## So any test migth be added as incompatible, the bug is not required.
+## So any test might be added as incompatible, the bug is not required.


typo: s/bug/bug-ID/

dcubed-ojdk · 2023-05-30T21:33:55Z

vmTestbase/nsk/jdi/VirtualMachine/instanceCounts/instancecounts002/TestDescription.java

has also shown up in the CI with same failure mode as the others...

lmesnik · 2023-05-31T00:09:23Z

/integrate

openjdk · 2023-05-31T00:11:13Z

Going to push as commit 327733c.
Since your change was applied there have been 30 commits pushed to the master branch:

1e6770f: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM
cb40db0: 8309134: Augment test/langtools/tools/javac/versions/Versions.java for JDK 21 language changes
de7fd1c: 8307944: ClassFileDumper should only load java.nio.file.Path if enabled
7891de3: 8297885: misc sun/security/pkcs11 tests timed out
323d6ce: 8308960: Decouple internal Version and OperatingSystem classes
1b8e6bf: 8308987: Update java.lang.Class to use javadoc snippets
04b0e78: 8307648: java/net/httpclient/ExpectContinueTest.java timed out
6b90b05: 8297878: KEM: Implementation
21af8ba: 8290499: new File(parent, "/") breaks normalization – creates File with slash at the end
804f198: 8308992: New test TestHFA fails with zero
... and 20 more: https://git.openjdk.org/jdk/compare/ca54f4e007ab0f13bec9aaf995d34c0ab3ba6452...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-05-31T00:11:24Z

@lmesnik Pushed as commit 327733c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8308986: Disable svc tests failing with virtual thread factory

5ed56e6

openjdk bot added the rfr Pull request is ready for review label May 27, 2023

openjdk bot added the serviceability serviceability-dev@openjdk.org label May 27, 2023

AlanBateman reviewed May 28, 2023

View reviewed changes

dholmes-ora approved these changes May 29, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 29, 2023

sspitsyn reviewed May 30, 2023

View reviewed changes

dcubed-ojdk suggested changes May 30, 2023

View reviewed changes

sspitsyn approved these changes May 30, 2023

View reviewed changes

more tests excluded.

2c06810

dcubed-ojdk approved these changes May 30, 2023

View reviewed changes

lmesnik added 2 commits May 30, 2023 18:07

comment fixed.

0e6269a

one more test added.

004ac70

openjdk bot added the integrated Pull request has been integrated label May 31, 2023

openjdk bot closed this May 31, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8308986: Disable svc tests failing with virtual thread factory #14193

8308986: Disable svc tests failing with virtual thread factory #14193

lmesnik commented May 27, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented May 27, 2023

openjdk bot commented May 27, 2023

lmesnik commented May 27, 2023

openjdk bot commented May 27, 2023

mlbridge bot commented May 27, 2023 •

edited

Loading

AlanBateman May 28, 2023 •

edited

Loading

dholmes-ora left a comment

openjdk bot commented May 29, 2023 •

edited

Loading

sspitsyn May 30, 2023

dcubed-ojdk May 30, 2023

dcubed-ojdk commented May 30, 2023

dcubed-ojdk May 30, 2023

sspitsyn commented May 30, 2023

sspitsyn left a comment •

edited

Loading

lmesnik commented May 30, 2023

dcubed-ojdk commented May 30, 2023

dcubed-ojdk left a comment

dcubed-ojdk May 30, 2023

dcubed-ojdk commented May 30, 2023

lmesnik commented May 31, 2023

openjdk bot commented May 31, 2023

openjdk bot commented May 31, 2023

8308986: Disable svc tests failing with virtual thread factory #14193

8308986: Disable svc tests failing with virtual thread factory #14193

Conversation

lmesnik commented May 27, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented May 27, 2023

openjdk bot commented May 27, 2023

lmesnik commented May 27, 2023

openjdk bot commented May 27, 2023

mlbridge bot commented May 27, 2023 • edited Loading

Webrevs

AlanBateman May 28, 2023 • edited Loading

Choose a reason for hiding this comment

dholmes-ora left a comment

Choose a reason for hiding this comment

openjdk bot commented May 29, 2023 • edited Loading

sspitsyn May 30, 2023

Choose a reason for hiding this comment

dcubed-ojdk May 30, 2023

Choose a reason for hiding this comment

dcubed-ojdk commented May 30, 2023

dcubed-ojdk May 30, 2023

Choose a reason for hiding this comment

sspitsyn commented May 30, 2023

sspitsyn left a comment • edited Loading

Choose a reason for hiding this comment

lmesnik commented May 30, 2023

dcubed-ojdk commented May 30, 2023

dcubed-ojdk left a comment

Choose a reason for hiding this comment

dcubed-ojdk May 30, 2023

Choose a reason for hiding this comment

dcubed-ojdk commented May 30, 2023

lmesnik commented May 31, 2023

openjdk bot commented May 31, 2023

openjdk bot commented May 31, 2023

lmesnik commented May 27, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented May 27, 2023 •

edited

Loading

AlanBateman May 28, 2023 •

edited

Loading

openjdk bot commented May 29, 2023 •

edited

Loading

sspitsyn left a comment •

edited

Loading