8309054: Parsing of erroneous patterns succeeds

[biboudis]

Moving the logic of type test pattern detection from parsePattern to variableDeclaratorRest in #13528 made the logic of the latter too complex. The regression in this JBS would be fixed by introducing two additional if-guards (e.g., if (!typePattern)); conditional on whether we are detecting a local variable or a type pattern. This PR removes this.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309054: Parsing of erroneous patterns succeeds

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14205/head:pull/14205
$ git checkout pull/14205

Update a local copy of the PR:
$ git checkout pull/14205
$ git pull https://git.openjdk.org/jdk.git pull/14205/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14205

View PR using the GUI difftool:
$ git pr show -t 14205

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14205.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@biboudis The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (864ad93a)

[lahodaj]

Looks good to me.

[openjdk]

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309054: Parsing of erroneous patterns succeeds

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 2b186e2: 8309042: MemorySegment::reinterpret cleanup action is not called for all overloads
• 78aac24: 8308881: Strong CLD oop handle roots are demoted to non-roots concurrently
• 1f1f604: 8302670: use-after-free related to PhaseIterGVN interaction with Unique_Node_List and Node_Stack
• d35a550: 8309077: Problemlist compiler/jvmci/TestUncaughtErrorInCompileMethod.java
• 457e1cb: 8308817: RISC-V: Support VectorTest node for Vector API
• 7508d9f: 8308906: Make CIPrintCompilerName a diagnostic flag
• a4bae3a: 8309060: Compilation Error in javax/swing/event/FocusEventCauseTest.java
• d73fc70: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
• 7cf6eec: 8307488: Incorrect weight of the first ObjectAllocationSample JFR event
• a5d8d59: 8308930: [JVMCI] TestUncaughtErrorInCompileMethod times out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lahodaj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[biboudis]

/integrate

[openjdk]

@biboudis
Your change (at version 864ad93) is now ready to be sponsored by a Committer.

[lahodaj]

/sponsor

[openjdk]

Going to push as commit 4f3a95a.
Since your change was applied there have been 31 commits pushed to the master branch:

• 4f16161: 8309044: Replace NULL with nullptr, final sweep of hotspot code
• 8823626: 8309048: Remove malloc locker test case
• 927a9ed: 8240774: [REDO] G1DirtyCardQueue destructor has useless flush
• 119994f: 8308997: RISC-V: Sign extend when comparing 32-bit value with zero instead of testing the sign bit
• 327733c: 8308986: Disable svc tests failing with virtual thread factory
• 1e6770f: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM
• cb40db0: 8309134: Augment test/langtools/tools/javac/versions/Versions.java for JDK 21 language changes
• de7fd1c: 8307944: ClassFileDumper should only load java.nio.file.Path if enabled
• 7891de3: 8297885: misc sun/security/pkcs11 tests timed out
• 323d6ce: 8308960: Decouple internal Version and OperatingSystem classes
• ... and 21 more: https://git.openjdk.org/jdk/compare/70130d3b16e76364ede72dec421ed6e7c40467fe...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj @biboudis Pushed as commit 4f3a95a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.