Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309956: Shenandoah: Strengthen the mark word check in string dedup #14455

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 13, 2023

See the bug for details.

Additional testing:

  • macos-aarch64-server-fastdebug, hotspot_gc_shenandoah

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309956: Shenandoah: Strengthen the mark word check in string dedup (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14455/head:pull/14455
$ git checkout pull/14455

Update a local copy of the PR:
$ git checkout pull/14455
$ git pull https://git.openjdk.org/jdk.git pull/14455/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14455

View PR using the GUI difftool:
$ git pr show -t 14455

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14455.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 13, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 13, 2023
@openjdk
Copy link

openjdk bot commented Jun 13, 2023

@shipilev The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jun 13, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 13, 2023

Webrevs

Copy link
Contributor

@earthling-amzn earthling-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Jun 13, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309956: Shenandoah: Strengthen the mark word check in string dedup

Reviewed-by: wkemper, zgu, ysr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 13, 2023
Copy link
Member

@ysramakrishna ysramakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@shipilev
Copy link
Member Author

Thank you all!

/integrate

@openjdk
Copy link

openjdk bot commented Jun 14, 2023

Going to push as commit 57b8251.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 955fc2f: 8309746: Reconfigure check should include make/conf/version-numbers.conf
  • 554b4d7: 8308585: AC_REQUIRE: `PLATFORM_EXTRACT_TARGET_AND_BUILD' was expanded before it was required
  • 84d010a: 8309928: JFR: View issues
  • 9872a14: 8309959: JFR: Display N/A for missing data amount
  • 4c18b9e: 8309880: Add support for linking libffi on Windows and Mac
  • 1d1ed0d: 8309957: Rename JDK-8309595 test to conform
  • e3d6fc8: 8309847: FrameForm and RegisterForm constructors should initialize all members

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 14, 2023
@openjdk openjdk bot closed this Jun 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 14, 2023
@openjdk
Copy link

openjdk bot commented Jun 14, 2023

@shipilev Pushed as commit 57b8251.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev
Copy link
Member Author

/backport jdk21

@openjdk
Copy link

openjdk bot commented Jun 14, 2023

@shipilev the backport was successfully created on the branch shipilev-backport-57b82512 in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 57b82512 from the openjdk/jdk repository.

The commit being backported was authored by Aleksey Shipilev on 14 Jun 2023 and was reviewed by William Kemper, Zhengyu Gu and Y. Srinivas Ramakrishna.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git shipilev-backport-57b82512:shipilev-backport-57b82512
$ git checkout shipilev-backport-57b82512
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git shipilev-backport-57b82512

@shipilev shipilev deleted the JDK-8309956-shenandoah-strdedup-check branch August 10, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
4 participants