Skip to content

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Jun 21, 2023

To make UTF-32 consistent with other UTF Charsets, making them available as StandardCharsets. A CSR has also been drafted.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8310251 to be approved

Issues

  • JDK-8310047: Add UTF-32 based Charsets into StandardCharsets (Enhancement - P4)
  • JDK-8310251: Add UTF-32 based Charsets into StandardCharsets (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14599/head:pull/14599
$ git checkout pull/14599

Update a local copy of the PR:
$ git checkout pull/14599
$ git pull https://git.openjdk.org/jdk.git pull/14599/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14599

View PR using the GUI difftool:
$ git pr show -t 14599

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14599.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2023

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jun 21, 2023
@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@naotoj The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jun 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2023

Webrevs

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hopefully we can convert the tests to junit at some point as started with some of the other tests in this area(to be done under a separate PR of course :-) )

Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
@openjdk
Copy link

openjdk bot commented Jul 11, 2023

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310047: Add UTF-32 based Charsets into StandardCharsets

Reviewed-by: alanb, lancea, bpb, jpai, jlu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 174 new commits pushed to the master branch:

  • 4b1403d: 8311548: AArch64: [ZGC] Many tests fail with "assert(allocates2(pc)) failed: not in CodeBuffer memory" on some CPUs
  • 940a4e1: 8304503: Modernize debugging jvm args in demo netbeans projects
  • 57e7e82: 8309637: runtime/handshake/HandshakeTimeoutTest.java fails with "has not cleared handshake op" and SIGILL
  • 63f32fb: 8311528: Remove IDE specific SuppressWarnings
  • b285ed7: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
  • 6569b25: 8311593: Minor doc issue in MemorySegment::copy
  • 623cfcd: 8310892: ScopedValue throwing StructureViolationException should be clearer
  • 06a1a15: 8311588: C2: RepeatCompilation compiler directive does not choose stress seed randomly
  • 581f90e: 8311604: Simplify NOCOOPS requested addresses for archived heap objects
  • 4a1fcb6: 8193513: add support for printing a stack trace on class loading
  • ... and 164 more: https://git.openjdk.org/jdk/compare/556831d1bf80a919330d9ca5330b4deef16592e2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Jul 11, 2023
@naotoj
Copy link
Member Author

naotoj commented Jul 11, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 11, 2023

Going to push as commit 00c7f91.
Since your change was applied there have been 177 commits pushed to the master branch:

  • caadad4: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if
  • b3f3403: 8311689: Wrong visible amount in Adjustable of ScrollPane
  • a1cfc96: 8311245: JFR: Remove t.printStackTrace() in PeriodicEvents
  • 4b1403d: 8311548: AArch64: [ZGC] Many tests fail with "assert(allocates2(pc)) failed: not in CodeBuffer memory" on some CPUs
  • 940a4e1: 8304503: Modernize debugging jvm args in demo netbeans projects
  • 57e7e82: 8309637: runtime/handshake/HandshakeTimeoutTest.java fails with "has not cleared handshake op" and SIGILL
  • 63f32fb: 8311528: Remove IDE specific SuppressWarnings
  • b285ed7: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
  • 6569b25: 8311593: Minor doc issue in MemorySegment::copy
  • 623cfcd: 8310892: ScopedValue throwing StructureViolationException should be clearer
  • ... and 167 more: https://git.openjdk.org/jdk/compare/556831d1bf80a919330d9ca5330b4deef16592e2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2023
@openjdk openjdk bot closed this Jul 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 11, 2023
@openjdk
Copy link

openjdk bot commented Jul 11, 2023

@naotoj Pushed as commit 00c7f91.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

7 participants