New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8257707: Fix incorrect format string in Http1HeaderParser #1495
8257707: Fix incorrect format string in Http1HeaderParser #1495
Conversation
👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into |
@turbanoff The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Submitted: https://bugs.openjdk.java.net/browse/JDK-8257707 -- rename this PR to "8257707: Fix incorrect format string in Http1HeaderParser" to get it hooked here. Also, merge from master to get Windows builds fixed and re-tested. |
68e5ae9
to
49e18af
Compare
Hi Andrey, Thanks for finding this. Could you run the HttpClient tests - and if they pass I'll sponsor the changes.
Alternatively you can run tier2 tests - which include the HttpClient changes:
(but that's going to run many more tests) best regards, -- daniel |
make test-tier2 fails with error on my machine: :(
|
That's the build failure, actually, and |
FWIW, this passes with the patch:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@turbanoff This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@turbanoff |
@dfuch, are you still good with this? Please submit your formal review here :) |
Thanks for running the tests Andrei. I will sponsor. |
/sponsor |
@dfuch @turbanoff Since your change was applied there have been 23 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit c6f93ec. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Few tests failed with
List of failed tests:
Looks like they are not related to my changes |
Incorrect format string was found by IntelliJ IDEA inspection
Java | Probable bugs | Malformed format string
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1495/head:pull/1495
$ git checkout pull/1495