8315580: Remove unused java_lang_String::set_value_raw()#15552
8315580: Remove unused java_lang_String::set_value_raw()#15552kimbarrett wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into |
|
@kimbarrett The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
shipilev
left a comment
There was a problem hiding this comment.
Looks fine.
AFAICS, the last use was removed here: 1ff4646#diff-1f28d52b3481c769173392d3f4183e45408edd3e9f8f645cfee424e6f720dd15L774
|
@kimbarrett This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Thanks for reviews @shipilev and @albertnetymk |
|
/integrate |
|
Going to push as commit b482e6d. |
|
@kimbarrett Pushed as commit b482e6d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this trivial change to remove the unused function java_lang_String::set_value_raw.
Testing:
mach5 tier1
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15552/head:pull/15552$ git checkout pull/15552Update a local copy of the PR:
$ git checkout pull/15552$ git pull https://git.openjdk.org/jdk.git pull/15552/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15552View PR using the GUI difftool:
$ git pr show -t 15552Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15552.diff
Webrev
Link to Webrev Comment