Skip to content

8310823: Materialize CDS archived objects with regular GC allocation #15730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

iklam
Copy link
Member

@iklam iklam commented Sep 13, 2023

This is a draft. No plans to integrate yet.

See https://bugs.openjdk.org/browse/JDK-8310823

And also discussions in a related PR #14520


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blockers

 ⚠️ Too few reviewers with at least role reviewer found (have 0, need at least 1) (failed with the updated jcheck configuration)
 ⚠️ Whitespace errors (failed with the updated jcheck configuration)

Issue

  • JDK-8310823: Materialize CDS archived objects with regular GC allocation (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15730/head:pull/15730
$ git checkout pull/15730

Update a local copy of the PR:
$ git checkout pull/15730
$ git pull https://git.openjdk.org/jdk.git pull/15730/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15730

View PR using the GUI difftool:
$ git pr show -t 15730

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15730.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2023

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@iklam this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8310823-materialize-cds-heap-with-regular-alloc.alternative-relocation
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@iklam The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 13, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 9, 2023

@iklam This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2024

@iklam This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org merge-conflict Pull request has merge conflict with target branch
Development

Successfully merging this pull request may close these issues.

1 participant