Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315882: Open some swing tests 2 #15850

Closed
wants to merge 10 commits into from

Conversation

alisenchung
Copy link
Contributor

@alisenchung alisenchung commented Sep 20, 2023

Moving some tests to open
5 javax/swing/ScrollPaneLayout/4688907/bug4688907.java
6 javax/swing/SpringLayout/4756178/bug4756178.java
7 javax/swing/SpringLayout/4803649/bug4803649.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15850/head:pull/15850
$ git checkout pull/15850

Update a local copy of the PR:
$ git checkout pull/15850
$ git pull https://git.openjdk.org/jdk.git pull/15850/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15850

View PR using the GUI difftool:
$ git pr show -t 15850

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15850.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2023

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@alisenchung The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 20, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 20, 2023

Webrevs

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated changes look good.

@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315882: Open some swing tests 2

Reviewed-by: honkar, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 261 new commits pushed to the master branch:

  • 68a9c81: 8316711: SEGV in LoaderConstraintTable::find_loader_constraint after JDK-8310874
  • e015e6c: 8315825: Open some swing tests
  • 9aaac2e: 8301639: JDI and JDWP specs should clarify potential deadlock issues with method invocation
  • 6b8261b: 8315464: Uncouple AllClassesIndexWriter from IndexBuilder
  • 9b65b7d: 8316305: Initial buffer size of StackWalker is too small caused by JDK-8285447
  • 53516ae: 8304956: Update KeyStore.getDefaultType​() specification to return pkcs12 as fallback
  • 373cdf2: 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind
  • f7578e8: 8316540: StoreReproducibilityTest fails on some locales
  • b66ded9: 8316688: Widen allowable error bound of Math.hypot
  • 6c61bc1: 8316514: Better diagnostic header for VtableStub
  • ... and 251 more: https://git.openjdk.org/jdk/compare/024133b089d911dcc3ea70dfdaa6b150b14a9eb4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 21, 2023
@alisenchung
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 23, 2023

Going to push as commit d2d7d9a.
Since your change was applied there have been 261 commits pushed to the master branch:

  • 68a9c81: 8316711: SEGV in LoaderConstraintTable::find_loader_constraint after JDK-8310874
  • e015e6c: 8315825: Open some swing tests
  • 9aaac2e: 8301639: JDI and JDWP specs should clarify potential deadlock issues with method invocation
  • 6b8261b: 8315464: Uncouple AllClassesIndexWriter from IndexBuilder
  • 9b65b7d: 8316305: Initial buffer size of StackWalker is too small caused by JDK-8285447
  • 53516ae: 8304956: Update KeyStore.getDefaultType​() specification to return pkcs12 as fallback
  • 373cdf2: 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files behind
  • f7578e8: 8316540: StoreReproducibilityTest fails on some locales
  • b66ded9: 8316688: Widen allowable error bound of Math.hypot
  • 6c61bc1: 8316514: Better diagnostic header for VtableStub
  • ... and 251 more: https://git.openjdk.org/jdk/compare/024133b089d911dcc3ea70dfdaa6b150b14a9eb4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 23, 2023
@openjdk openjdk bot closed this Sep 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 23, 2023
@openjdk
Copy link

openjdk bot commented Sep 23, 2023

@alisenchung Pushed as commit d2d7d9a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants