8257651: LambdaEagerInit.java test failed in 2 different ways

[calvinccheung]

Please review this simple change for fixing the 2 issues as described in the bug report.

• exclude the test from the hotspot_appcds_dynamic test group.

• compile Asserts.java so that the class file will be located under the following dir .../JTwork/classes/.../runtime/cds/appcds/LambdaEagerInit.d/jdk/test/lib/

Passed hs-tier4 tests.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8257651: LambdaEagerInit.java test failed in 2 different ways

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Lois Foltan (@lfoltan - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1616/head:pull/1616
$ git checkout pull/1616

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[calvinccheung]

/label remove hotspot
/label add hotspot-runtime

[openjdk]

@calvinccheung The hotspot label was not set.

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (17b8633)

[iklam]

Looks good to me.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257651: LambdaEagerInit.java test failed in 2 different ways

Reviewed-by: iklam, lfoltan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• 3eb6946: 8257732: Problem list TestJFRWithJMX for OL 8.2 until the issue is resolved
• ac54900: 8257401: Use switch expressions in jdk.internal.net.http and java.net.http
• 86b6575: 8257574: C2: "failed: parsing found no loops but there are some" assert failure
• dede01e: 8257622: MemoryAccess methods are missing @ForceInline annotations
• 1d2d981: 8257423: [PPC64] Support -XX:-UseInlineCaches
• feabdde: 8251843: jfr/tool/TestPrintJSON.java fails intermittently
• c6f93ec: 8257707: Fix incorrect format string in Http1HeaderParser
• fbdc187: 8257624: C2: PhaseMacroExpand::eliminate_macro_nodes() crashes on out-of-bounds access into macro node array
• fd6756e: 8257634: C2: Introduce IncrementalInliningForceCleanup diagnostic flag
• af6b7f9: 8257743: Minimal build on AArch64 failed with --disable-precompiled-headers
• ... and 24 more: https://git.openjdk.java.net/jdk/compare/e83639620739749834d91e026cfecb56529aa295...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lfoltan]

Looks good Calvin!
Lois

[calvinccheung]

Thanks @iklam and @lfoltan for the review.

[calvinccheung]

/integrate

[openjdk]

@calvinccheung Since your change was applied there have been 34 commits pushed to the master branch:

• 3eb6946: 8257732: Problem list TestJFRWithJMX for OL 8.2 until the issue is resolved
• ac54900: 8257401: Use switch expressions in jdk.internal.net.http and java.net.http
• 86b6575: 8257574: C2: "failed: parsing found no loops but there are some" assert failure
• dede01e: 8257622: MemoryAccess methods are missing @ForceInline annotations
• 1d2d981: 8257423: [PPC64] Support -XX:-UseInlineCaches
• feabdde: 8251843: jfr/tool/TestPrintJSON.java fails intermittently
• c6f93ec: 8257707: Fix incorrect format string in Http1HeaderParser
• fbdc187: 8257624: C2: PhaseMacroExpand::eliminate_macro_nodes() crashes on out-of-bounds access into macro node array
• fd6756e: 8257634: C2: Introduce IncrementalInliningForceCleanup diagnostic flag
• af6b7f9: 8257743: Minimal build on AArch64 failed with --disable-precompiled-headers
• ... and 24 more: https://git.openjdk.java.net/jdk/compare/e83639620739749834d91e026cfecb56529aa295...master

Your commit was automatically rebased without conflicts.

Pushed as commit d8ac76f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.