8322159: ThisEscapeAnalyzer crashes for erroneous code

[lahodaj]

When an unresolvable method is used in the code, the model is a bit strange (and not very easy to fix) - for method invocations, the symbol used is actually a ClassSymbol instead of MethodSymbol, and method references have fields like kind unfilled.

This is causing issues in ThisEscapeAnalyzer when there were unresolvable methods, and the analyzer is called (i.e. in practice when running with -Xlint:this-escape -XDshould-stop.at=FLOW, or similar):

• visitApply has a hardcoded cast to MethodSymbol. Seems the case in not really necessary, so the proposal is to remove it.
• visitReference crashes on an access to JCMemberReference.kind, as it is unfilled. The proposal is to skip the check if the method reference's type is errneous.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8322159: ThisEscapeAnalyzer crashes for erroneous code (Bug - P3)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/17118/head:pull/17118
$ git checkout pull/17118

Update a local copy of the PR:
$ git checkout pull/17118
$ git pull https://git.openjdk.org/jdk.git pull/17118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17118

View PR using the GUI difftool:
$ git pr show -t 17118

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/17118.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9b59e852)

[archiecobbs]

Hi @lahodaj,

Looks good to me - thanks for fixing.

[vicente-romero-oracle]

looks sensible

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322159: ThisEscapeAnalyzer crashes for erroneous code

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 83 new commits pushed to the master branch:

• d4fb308: 8317846: Typo in API documentation of classes IdentityHashMap
• d786c49: 8322751: ZGC: Fix comments about marking roots
• 5852f3e: 8322027: One XMLStreamException constructor fails to initialize cause
• be0e1c7: 8297573: Parallel: Rename do_oop_nv to do_oop_work in subclasses of OopClosure
• 7c1d481: 8322765: Eliminate -Wparentheses warnings in runtime code
• 518ec97: 8322747: StringTable should be AllStatic
• 32d80e2: 8322772: Clean up code after JDK-8322417
• 19147f3: 8318158: RISC-V: implement roundD/roundF intrinsics
• 2a59243: 8322734: A redundant return in method padWithLen
• 4fc6b0f: 8068958: Timestamp.from(Instant) should throw when conversion is not possible
• ... and 73 more: https://git.openjdk.org/jdk/compare/62b7c5eaed1e6ffd6f2c8371eb4cf01dd9d53a06...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/backport jdk22

[lahodaj]

/integrate

[openjdk]

@lahodaj Backport for repo openjdk/jdk22 on branch master was successfully enabled and will be performed once this pull request has been integrated. Further instructions will be provided at that time.

[openjdk]

Going to push as commit 7455b1b.
Since your change was applied there have been 83 commits pushed to the master branch:

• d4fb308: 8317846: Typo in API documentation of classes IdentityHashMap
• d786c49: 8322751: ZGC: Fix comments about marking roots
• 5852f3e: 8322027: One XMLStreamException constructor fails to initialize cause
• be0e1c7: 8297573: Parallel: Rename do_oop_nv to do_oop_work in subclasses of OopClosure
• 7c1d481: 8322765: Eliminate -Wparentheses warnings in runtime code
• 518ec97: 8322747: StringTable should be AllStatic
• 32d80e2: 8322772: Clean up code after JDK-8322417
• 19147f3: 8318158: RISC-V: implement roundD/roundF intrinsics
• 2a59243: 8322734: A redundant return in method padWithLen
• 4fc6b0f: 8068958: Timestamp.from(Instant) should throw when conversion is not possible
• ... and 73 more: https://git.openjdk.org/jdk/compare/62b7c5eaed1e6ffd6f2c8371eb4cf01dd9d53a06...master

Your commit was automatically rebased without conflicts.

[openjdk]

Creating backport for repo openjdk/jdk22 on branch master

/backport openjdk/jdk22 master

[openjdk]

@lahodaj Pushed as commit 7455b1b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[openjdk]

@openjdk[bot] @lahodaj the backport was successfully created on the branch backport-lahodaj-7455b1b5 in my personal fork of openjdk/jdk22. To create a pull request with this backport targeting openjdk/jdk22:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 7455b1b5 from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 2 Jan 2024 and was reviewed by Vicente Romero.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22:

$ git fetch https://github.com/openjdk-bots/jdk22.git backport-lahodaj-7455b1b5:backport-lahodaj-7455b1b5
$ git checkout backport-lahodaj-7455b1b5
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22.git backport-lahodaj-7455b1b5

[lahodaj]

/backport jdk22u

[openjdk]

@lahodaj the backport was successfully created on the branch backport-lahodaj-7455b1b5 in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 7455b1b5 from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 2 Jan 2024 and was reviewed by Vicente Romero.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-lahodaj-7455b1b5:backport-lahodaj-7455b1b5
$ git checkout backport-lahodaj-7455b1b5
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-lahodaj-7455b1b5

⚠️ @lahodaj You are not yet a collaborator in my fork openjdk-bots/jdk22u. An invite will be sent out and you need to accept it before you can proceed.