-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal #18085
Conversation
👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@dougxc This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
One day, somebody among us will implement timeouts that take into account whether there are JVM options like -Xcomp or other factors that slow things down... 8-)
Thanks for the reviews. /integrate |
Going to push as commit 8f0fb27.
Your commit was automatically rebased without conflicts. |
To account for slightly slower compile times on libgraal + fastdebug +
-Xcomp
, this PR increases a timeout inNotifReconnectDeadlockTest.java
from 2000 ms to 3000 ms.With this change, the test now reliably passes.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18085/head:pull/18085
$ git checkout pull/18085
Update a local copy of the PR:
$ git checkout pull/18085
$ git pull https://git.openjdk.org/jdk.git pull/18085/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18085
View PR using the GUI difftool:
$ git pr show -t 18085
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18085.diff
Webrev
Link to Webrev Comment