Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal #18085

Closed
wants to merge 1 commit into from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Mar 1, 2024

To account for slightly slower compile times on libgraal + fastdebug + -Xcomp, this PR increases a timeout in NotifReconnectDeadlockTest.java from 2000 ms to 3000 ms.
With this change, the test now reliably passes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18085/head:pull/18085
$ git checkout pull/18085

Update a local copy of the PR:
$ git checkout pull/18085
$ git pull https://git.openjdk.org/jdk.git pull/18085/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18085

View PR using the GUI difftool:
$ git pr show -t 18085

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18085.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2024

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@dougxc The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org labels Mar 1, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2024

Webrevs

Copy link
Contributor

@tkrodriguez tkrodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal

Reviewed-by: never, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • b38a6c5: 8327049: Only export debug.cpp functions on Windows
  • acc0a74: 8327126: Parallel: Remove unused ParMarkBitMapClosure::_initial_words_remaining
  • 012411a: 8327046: (fs) Files.walk should be clear that depth-first traversal is pre-order
  • 98434d6: 8322170: Update deprecated/obsolete/expired flags table for GC
  • c02e7f4: 8327058: RISC-V: make Zcb experimental
  • b972997: 8326974: ODR violation in macroAssembler_aarch64.cpp
  • 437cf35: 8319648: java/lang/SecurityManager tests ignore vm flags
  • e85265a: 8325361: Make sun.net.www.MessageHeader final
  • 5b75199: 8327022: Parallel: Remove experimental dense prefix calculation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 1, 2024
Copy link
Contributor

@kevinjwalls kevinjwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

One day, somebody among us will implement timeouts that take into account whether there are JVM options like -Xcomp or other factors that slow things down... 8-)

@dougxc
Copy link
Member Author

dougxc commented Mar 1, 2024

Thanks for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 1, 2024

Going to push as commit 8f0fb27.
Since your change was applied there have been 9 commits pushed to the master branch:

  • b38a6c5: 8327049: Only export debug.cpp functions on Windows
  • acc0a74: 8327126: Parallel: Remove unused ParMarkBitMapClosure::_initial_words_remaining
  • 012411a: 8327046: (fs) Files.walk should be clear that depth-first traversal is pre-order
  • 98434d6: 8322170: Update deprecated/obsolete/expired flags table for GC
  • c02e7f4: 8327058: RISC-V: make Zcb experimental
  • b972997: 8326974: ODR violation in macroAssembler_aarch64.cpp
  • 437cf35: 8319648: java/lang/SecurityManager tests ignore vm flags
  • e85265a: 8325361: Make sun.net.www.MessageHeader final
  • 5b75199: 8327022: Parallel: Remove experimental dense prefix calculation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 1, 2024
@openjdk openjdk bot closed this Mar 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@dougxc Pushed as commit 8f0fb27.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated jmx jmx-dev@openjdk.org serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants