Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253169: [BACKOUT] Improve large object handling during evacuation #181

Closed
wants to merge 1 commit into from

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Sep 15, 2020

Revert "8027545: Improve object array chunking test in G1's copy_to_survivor_space"
Revert "8158045: Improve large object handling during evacuation"
Revert "8027761: Investigate fast-path for scanning only objects with references during gc"

This reverts commit dafcf10.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253169: [BACKOUT] Improve large object handling during evacuation

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/181/head:pull/181
$ git checkout pull/181

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2020

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@kimbarrett The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot label Sep 15, 2020
@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Sep 15, 2020

/label add hotspot-gc
/label remove hotspot

@openjdk openjdk bot added the hotspot-gc label Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@kimbarrett
The hotspot-gc label was successfully added.

@openjdk openjdk bot removed the hotspot label Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@kimbarrett
The hotspot label was successfully removed.

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Sep 15, 2020

/summary
Revert "8027545: Improve object array chunking test in G1's copy_to_survivor_space"
Revert "8158045: Improve large object handling during evacuation"
Revert "8027761: Investigate fast-path for scanning only objects with references during gc"

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@kimbarrett Setting summary to:

Revert "8027545: Improve object array chunking test in G1's copy_to_survivor_space"
Revert "8158045: Improve large object handling during evacuation"
Revert "8027761: Investigate fast-path for scanning only objects with references during gc"

@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Sep 15, 2020

Currently doing test builds of all Oracle supported platforms.

@kimbarrett kimbarrett marked this pull request as ready for review Sep 15, 2020
@openjdk openjdk bot added the rfr label Sep 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2020

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Looks like a legit backout.

Copy link
Contributor

@kstefanj kstefanj left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@kimbarrett This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253169: [BACKOUT] Improve large object handling during evacuation

Revert "8027545: Improve object array chunking test in G1's copy_to_survivor_space"
Revert "8158045: Improve large object handling during evacuation"
Revert "8027761: Investigate fast-path for scanning only objects with references during gc"

Reviewed-by: tschatzl, sjohanss
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • b5620a3: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b5620a36f4393049253e23267fb1522d172b281c.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 15, 2020
@kimbarrett
Copy link
Author

@kimbarrett kimbarrett commented Sep 15, 2020

/integrate

@openjdk openjdk bot closed this Sep 15, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@kimbarrett Since your change was applied there has been 1 commit pushed to the master branch:

  • b5620a3: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming

Your commit was automatically rebased without conflicts.

Pushed as commit 74851c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the backout_partial_arrays branch Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants