Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258896: Remove the JVM ForceFloatExceptions option #1932

Closed
wants to merge 3 commits into from

Conversation

@hseigel
Copy link
Member

@hseigel hseigel commented Jan 4, 2021

Please review this change to replace the JVM ForceFloatExceptions flag with #ifdef (_DEBUG). The change was tested with tiers 1 and 2 on Linux, Windows, and Mac OS, and tiers 3-5 on Windows x64.

Thanks, Harold


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258896: Remove the JVM ForceFloatExceptions option

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1932/head:pull/1932
$ git checkout pull/1932

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 4, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2021

@hseigel The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 4, 2021

Webrevs

lfoltan
lfoltan approved these changes Jan 4, 2021
Copy link
Member

@lfoltan lfoltan left a comment

LGTM.
Lois

@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258896: Remove the JVM ForceFloatExceptions option

Reviewed-by: lfoltan, iklam, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • fc3b45c: 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"
  • a6c0881: 8256321: Some "inactive" color profiles use the wrong profile class
  • 9f15164: 8259049: Uninitialized variable after JDK-8257513
  • db6f393: 8251944: Add Shenandoah test config to compiler/gcbarriers/UnsafeIntrinsicsTest.java
  • 3817c32: 8258534: Epsilon: clean up unused includes
  • 17d1645: 8258751: Improve ExceptionHandlerTable dump
  • dd8996c: 8258946: Fix optimization-unstable code involving signed integer overflow
  • 5ea9607: 8258459: Decouple gc_globals.hpp from globals.hpp
  • 2499ac3: 8259069: Fields could be final
  • f0aae81: 8259020: null-check of g1 write_ref_field_pre_entry is not necessary
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/d679caa28d5b2c8e9a385d57323f2f03a77ec1ba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 4, 2021
@hseigel
Copy link
Member Author

@hseigel hseigel commented Jan 4, 2021

Thanks Lois and Ioi for reviewing this change. Please review the updated commit that removes the unneeded consts, as suggested by Ioi.

Thanks, Harold

iklam
iklam approved these changes Jan 4, 2021
Copy link
Member

@iklam iklam left a comment

LGTM

src/hotspot/os/windows/os_windows.cpp Outdated Show resolved Hide resolved
coleenp
coleenp approved these changes Jan 5, 2021
Copy link
Contributor

@coleenp coleenp left a comment

Good find Kim. LGTM.

lfoltan
lfoltan approved these changes Jan 5, 2021
Copy link
Member

@lfoltan lfoltan left a comment

LGTM.
Lois

@hseigel
Copy link
Member Author

@hseigel hseigel commented Jan 5, 2021

Thanks for the reviews!

/integrate

@openjdk openjdk bot closed this Jan 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 5, 2021

@hseigel Since your change was applied there have been 14 commits pushed to the master branch:

  • fc3b45c: 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"
  • a6c0881: 8256321: Some "inactive" color profiles use the wrong profile class
  • 9f15164: 8259049: Uninitialized variable after JDK-8257513
  • db6f393: 8251944: Add Shenandoah test config to compiler/gcbarriers/UnsafeIntrinsicsTest.java
  • 3817c32: 8258534: Epsilon: clean up unused includes
  • 17d1645: 8258751: Improve ExceptionHandlerTable dump
  • dd8996c: 8258946: Fix optimization-unstable code involving signed integer overflow
  • 5ea9607: 8258459: Decouple gc_globals.hpp from globals.hpp
  • 2499ac3: 8259069: Fields could be final
  • f0aae81: 8259020: null-check of g1 write_ref_field_pre_entry is not necessary
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/d679caa28d5b2c8e9a385d57323f2f03a77ec1ba...master

Your commit was automatically rebased without conflicts.

Pushed as commit f4122d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants