Skip to content

8258796: [test] Apply HexFormat to tests for java.security #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Jan 8, 2021

Followup to the addition of java.util.HexFormat.
Uses of adhoc hexadecimal conversions are replaced with HexFormat.
Redundant utility methods are modified or removed.
In a few places the data being printed is ASN.1 and the test utility HexPrinter with the ASNFormatter is added.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258796: [test] Apply HexFormat to tests for java.security

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2006/head:pull/2006
$ git checkout pull/2006

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2021

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 8, 2021
@openjdk
Copy link

openjdk bot commented Jan 8, 2021

@RogerRiggs The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jan 8, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 8, 2021

Webrevs

@RogerRiggs
Copy link
Contributor Author

Removing the hotspot-runtime label to avoid spamming that alias.
Add it back if it is warranted.

/label remove hotspot-runtime

@openjdk openjdk bot removed the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 8, 2021
@openjdk
Copy link

openjdk bot commented Jan 8, 2021

@RogerRiggs
The hotspot-runtime label was successfully removed.

Copy link
Member

@XueleiFan XueleiFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@openjdk
Copy link

openjdk bot commented Jan 8, 2021

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258796: [test] Apply HexFormat to tests for java.security

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 8, 2021
@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Jan 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 8, 2021
@openjdk
Copy link

openjdk bot commented Jan 8, 2021

@RogerRiggs Since your change was applied there have been 36 commits pushed to the master branch:

  • 876c7fb: 8259493: [test] Use HexFormat instead of adhoc hex utilities in network code and locale SoftKeys
  • 090bd3a: 8259397: ThreadsSMRSupport::print_info_on() should use try_lock_without_rank_check()
  • 10a6b0d: 8234773: Fix ThreadsSMRSupport::_bootstrap_list
  • 6f7723b: 8258792: LogCompilation: remove redundant check fixed by 8257518
  • 697bf7a: 8257740: Compiler crash when compiling type annotation on multicatch inside lambda
  • b549cbd: 8258481: gc.g1.plab.TestPLABPromotion fails on Linux x86
  • fc1d2a1: 8259065: Optimize MessageDigest.getInstance
  • 712014c: 8258077: Using -Xcheck:jni can lead to a double-free after JDK-8193234
  • 56a354e: Merge
  • 677802d: 8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006
  • ... and 26 more: https://git.openjdk.java.net/jdk/compare/d8ad63019a8fae6665c2c5545635e6f0b750a780...master

Your commit was automatically rebased without conflicts.

Pushed as commit 628c546.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8258796-security-tests-hexformat branch January 9, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants