Skip to content

Use switch expressions and multiple labels switch case statements in jdk.javadoc #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

amCap1712
Copy link
Contributor

@amCap1712 amCap1712 commented Jan 11, 2021

Hi!
I propose to use switch expressions and multiple case label switch statements in the jdk.javadoc module with the intent to improve the readability of the code and make it more concise.
Thanks.
Regards,
Kartik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2023/head:pull/2023
$ git checkout pull/2023

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2021

👋 Welcome back amCap1712! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 11, 2021

@amCap1712 The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Jan 11, 2021
@amCap1712 amCap1712 changed the title Use switch expressions and multiple labels in switch case statements Use switch expressions and multiple labels switch case statements in jdk.javadoc Jan 11, 2021
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this sort of IDE-based cleanup is a mixed blessing. It can cause unnecessary conflicts with other ongoing work, and it can cause problems when trying to backport other fixes to earlier releases.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2021

@amCap1712 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2021

@amCap1712 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javadoc javadoc-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants