Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8202880: Test javax/swing/JPopupMenu/8075063/ContextMenuScrollTest.java fails #2061

Closed
wants to merge 5 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jan 13, 2021

This test was unstable in linux in nightly testing. Modified to move the frame to center of screen so that the left-taskbar of linux doesn't interfere with the mouse movement along with delay after frame is visible to make it more stable.
Mach5 job running for several iterations on all platforms is ok. Link in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8202880: Test javax/swing/JPopupMenu/8075063/ContextMenuScrollTest.java fails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2061/head:pull/2061
$ git checkout pull/2061

@prsadhuk
Copy link
Contributor Author

/label add swing

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review swing client-libs-dev@openjdk.org labels Jan 13, 2021
@openjdk
Copy link

openjdk bot commented Jan 13, 2021

@prsadhuk
The swing label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jan 13, 2021

Webrevs

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright year in the test and in the ProblemList.txt, since it exists there, should be updated.

@prsadhuk
Copy link
Contributor Author

@aivanov-jdk any more comment on this?

@openjdk
Copy link

openjdk bot commented Jan 15, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8202880: Test javax/swing/JPopupMenu/8075063/ContextMenuScrollTest.java fails

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 71 new commits pushed to the master branch:

  • d7d34dd: 8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect
  • fe84ecd: 8259048: (tz) Upgrade time-zone data to tzdata2020f
  • 9aa5672: 8259068: Streamline class loader locking
  • 27a39c8: 8193031: Collections.addAll is likely to perform worse than Collection.addAll
  • 5855d52: 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
  • 360c722: 8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
  • b78cd63: 8259846: [BACKOUT] JDK-8259278 Optimize Vector API slice and unslice operations
  • eb7fa00: 8259216: javadoc omits method receiver for any nested type annotation
  • bcf20a0: 8259777: Incorrect predication condition generated by ADLC
  • bbac91a: 8257959: Add gtest run with -XX:+UseLargePages
  • ... and 61 more: https://git.openjdk.java.net/jdk/compare/a483869a6a98ccf296763732a32894f6a39fff40...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 15, 2021
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Jan 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 18, 2021
@openjdk
Copy link

openjdk bot commented Jan 18, 2021

@prsadhuk Since your change was applied there have been 83 commits pushed to the master branch:

  • 68cf65d: 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1
  • 5dc5d94: 8256110: Create implementation for NSAccessibilityStepper protocol
  • 5f2e280: 8259865: (fs) test/jdk/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java failing on macOS 10.13
  • da4cf05: 8258755: jpackage: Invalid 32-bit exe when building app-image
  • c3bdbf9: 8259238: Clean up Log.java and remove usage of non-final static variables.
  • 6d6a23e: 8259062: Remove MacAppStoreBundler
  • afd3f78: 8030048: (fs) Support UserDefinedFileAttributeView/extended attributes on OS X / HFS+
  • bbb93ca: 8256126: Create implementation for NSAccessibilityImage protocol peer
  • 90c73d0: 8259569: gtest os.dll_address_to_function_and_library_name_vm fails
  • 536082d: Merge
  • ... and 73 more: https://git.openjdk.java.net/jdk/compare/a483869a6a98ccf296763732a32894f6a39fff40...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3f19ef6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8202880 branch January 18, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
2 participants