Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259398: Super word not applied to a loop with byteArrayViewVarHandle #2317

Closed
wants to merge 1 commit into from

Conversation

vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Jan 29, 2021

Address expressing in this case has CastII which is not range check related.
I think it is safe to skip any CastII nodes (similar to ConvI2L nodes) when parsing address for vectors - vectors will be constructed only if the same loop's variable and invariant are used for all memory operations regardless casts. Also vectors address depends on loop's variable so they will not be moved outside loop.
In 32-bit VM there is no ConvI2L nodes so I moved CastII checks from under ConvI2L check.

New regression case added to TestBufferVectorization.java test.

Testing hs-tier1-7, RenaissanceStressTest. Run all vectorizing tests locally to make sure no regression.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259398: Super word not applied to a loop with byteArrayViewVarHandle

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2317/head:pull/2317
$ git checkout pull/2317

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2021

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 29, 2021
@openjdk
Copy link

openjdk bot commented Jan 29, 2021

@vnkozlov The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jan 29, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2021

Webrevs

Copy link

@iwanowww iwanowww left a comment

Looks good.

@openjdk
Copy link

openjdk bot commented Jan 29, 2021

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259398: Super word not applied to a loop with byteArrayViewVarHandle

Reviewed-by: vlivanov, thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • aec0377: 8257498: Remove useless skeleton predicates
  • ab727f0: 8260591: Shenandoah: improve parallelism for concurrent thread root scans
  • cf94208: 8259395: Patching automatic module with additional packages re-creates module without "requires java.base"
  • 039affc: 8260577: Unused code in AbstractCompiler after Shark compiler removal
  • 8a9004d: 8260574: Remove parallel constructs in GenCollectedHeap::process_roots
  • 0da9cad: 8260501: [Vector API] Improve register usage for shift operations on x86
  • a61ff87: 8260685: ProblemList 2 compiler/jvmci/compilerToVM tests in Xcomp configs
  • fcfe647: 8260462: Missing in Modality.html
  • 67a34da: 8260630: Templatize literal_size
  • 6b24e98: 8259008: ArithmeticException was thrown at "Monitor Cache Dump" on HSDB
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/6415d3b82b68682fd19144c8e9c91459f20c7f3a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 29, 2021
@vnkozlov
Copy link
Contributor Author

vnkozlov commented Jan 29, 2021

Thank you @iwanowww

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

Copy link
Member

@chhagedorn chhagedorn left a comment

Looks good!

@vnkozlov
Copy link
Contributor Author

vnkozlov commented Feb 1, 2021

Thank you all

@vnkozlov
Copy link
Contributor Author

vnkozlov commented Feb 1, 2021

Thank you all for reviews.

@vnkozlov
Copy link
Contributor Author

vnkozlov commented Feb 1, 2021

/integrate

@openjdk openjdk bot closed this Feb 1, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2021
@openjdk
Copy link

openjdk bot commented Feb 1, 2021

@vnkozlov Since your change was applied there have been 18 commits pushed to the master branch:

  • 80760a3: 8260669: Missing quotes in fixpath.sh
  • c0cde7d: 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues
  • aec0377: 8257498: Remove useless skeleton predicates
  • ab727f0: 8260591: Shenandoah: improve parallelism for concurrent thread root scans
  • cf94208: 8259395: Patching automatic module with additional packages re-creates module without "requires java.base"
  • 039affc: 8260577: Unused code in AbstractCompiler after Shark compiler removal
  • 8a9004d: 8260574: Remove parallel constructs in GenCollectedHeap::process_roots
  • 0da9cad: 8260501: [Vector API] Improve register usage for shift operations on x86
  • a61ff87: 8260685: ProblemList 2 compiler/jvmci/compilerToVM tests in Xcomp configs
  • fcfe647: 8260462: Missing in Modality.html
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/6415d3b82b68682fd19144c8e9c91459f20c7f3a...master

Your commit was automatically rebased without conflicts.

Pushed as commit 02d586e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vnkozlov vnkozlov deleted the JDK-8259398 branch Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants