8259398: Super word not applied to a loop with byteArrayViewVarHandle

[vnkozlov]

Address expressing in this case has CastII which is not range check related.
I think it is safe to skip any CastII nodes (similar to ConvI2L nodes) when parsing address for vectors - vectors will be constructed only if the same loop's variable and invariant are used for all memory operations regardless casts. Also vectors address depends on loop's variable so they will not be moved outside loop.
In 32-bit VM there is no ConvI2L nodes so I moved CastII checks from under ConvI2L check.

New regression case added to TestBufferVectorization.java test.

Testing hs-tier1-7, RenaissanceStressTest. Run all vectorizing tests locally to make sure no regression.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259398: Super word not applied to a loop with byteArrayViewVarHandle

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2317/head:pull/2317
$ git checkout pull/2317

[bridgekeeper]

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vnkozlov The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fb3d4ff)

[iwanowww]

Looks good.

[openjdk]

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259398: Super word not applied to a loop with byteArrayViewVarHandle

Reviewed-by: vlivanov, thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• aec0377: 8257498: Remove useless skeleton predicates
• ab727f0: 8260591: Shenandoah: improve parallelism for concurrent thread root scans
• cf94208: 8259395: Patching automatic module with additional packages re-creates module without "requires java.base"
• 039affc: 8260577: Unused code in AbstractCompiler after Shark compiler removal
• 8a9004d: 8260574: Remove parallel constructs in GenCollectedHeap::process_roots
• 0da9cad: 8260501: [Vector API] Improve register usage for shift operations on x86
• a61ff87: 8260685: ProblemList 2 compiler/jvmci/compilerToVM tests in Xcomp configs
• fcfe647: 8260462: Missing in Modality.html
• 67a34da: 8260630: Templatize literal_size
• 6b24e98: 8259008: ArithmeticException was thrown at "Monitor Cache Dump" on HSDB
• ... and 6 more: https://git.openjdk.java.net/jdk/compare/6415d3b82b68682fd19144c8e9c91459f20c7f3a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vnkozlov]

Thank you @iwanowww

[TobiHartmann]

Looks good to me.

[chhagedorn]

Looks good!

[vnkozlov]

Thank you all

[vnkozlov]

Thank you all for reviews.

[vnkozlov]

/integrate

[openjdk]

@vnkozlov Since your change was applied there have been 18 commits pushed to the master branch:

• 80760a3: 8260669: Missing quotes in fixpath.sh
• c0cde7d: 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues
• aec0377: 8257498: Remove useless skeleton predicates
• ab727f0: 8260591: Shenandoah: improve parallelism for concurrent thread root scans
• cf94208: 8259395: Patching automatic module with additional packages re-creates module without "requires java.base"
• 039affc: 8260577: Unused code in AbstractCompiler after Shark compiler removal
• 8a9004d: 8260574: Remove parallel constructs in GenCollectedHeap::process_roots
• 0da9cad: 8260501: [Vector API] Improve register usage for shift operations on x86
• a61ff87: 8260685: ProblemList 2 compiler/jvmci/compilerToVM tests in Xcomp configs
• fcfe647: 8260462: Missing in Modality.html
• ... and 8 more: https://git.openjdk.java.net/jdk/compare/6415d3b82b68682fd19144c8e9c91459f20c7f3a...master

Your commit was automatically rebased without conflicts.

Pushed as commit 02d586e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.