8360979: Remove use of Thread.stop in krb5/auto/KDC.java

[myankelev]

Replaced Thread::stop to Thread::interrupt

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8360979: Remove use of Thread.stop in krb5/auto/KDC.java (Bug - P4)

Reviewers

• Weijun Wang (@wangweij - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26247/head:pull/26247
$ git checkout pull/26247

Update a local copy of the PR:
$ git checkout pull/26247
$ git pull https://git.openjdk.org/jdk.git pull/26247/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26247

View PR using the GUI difftool:
$ git pr show -t 26247

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26247.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back myankelevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@myankelev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360979: Remove use of Thread.stop in krb5/auto/KDC.java

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1134 new commits pushed to the master branch:

• e8adc1f: 8367989: Remove InstanceKlass::allocate_objArray and ArrayKlass::allocate_arrayArray
• 2313f8e: 8368366: RISC-V: AlignVector is mistakenly set to AvoidUnalignedAccesses
• 288822a: 8367068: Remove redundant HttpRequest.BodyPublisher tests
• ... and 1131 more: https://git.openjdk.org/jdk/compare/aa1911191cf8c2b855268a76baf0757909d66d1b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@myankelev The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (08c49f42)
• 00: Full (64e641c5)

[mpdonova]

The comments are probably unnecessary; the InterruptedException tells us that the thread was stopped/interrupted.

[myankelev]

I would disagree, this seems to be a common mistake in my experience. While this is obvious, it helps to draw the developer's attention, in case the code is ever changed

[bridgekeeper]

@myankelev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@myankelev This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[myankelev]

/open

[openjdk]

@myankelev This pull request is now open

[wangweij]

Thanks for fixing this. The terminate method is only called once when the KDC has its own sub-process. In that case, since the threads are daemons there is really no need to interrupt them. The fix looks good but I don't know how effective it is if a test really needs to start a KDC, terminate it, and then start it on the same port.

[myankelev]

Thanks for fixing this. The terminate method is only called once when the KDC has its own sub-process. In that case, since the threads are daemons there is really no need to interrupt them. The fix looks good but I don't know how effective it is if a test really needs to start a KDC, terminate it, and then start it on the same port.

This pr just replaces the thread.stop with the same functionality without changing the logic of the test. Do you propose reworking test and removing the interruption all together?

[wangweij]

The fix looks fine. I might be only questioning the quality of the original test.

[myankelev]

Thanks for the review @wangweij! I've created JDK-8368561 to revisit and review the test logic itself to make it simpler if possible.
/integrate

[openjdk]

Going to push as commit 2a232d0.
Since your change was applied there have been 1137 commits pushed to the master branch:

• 1cd186c: 8368331: ClassFile Signature parsing fails for type parameter with no supertype
• 0a64358: 8368273: LIBPTHREAD dependency is not needed for some jdk libs
• 727d41d: 8368226: Remove Thread.stop
• ... and 1134 more: https://git.openjdk.org/jdk/compare/aa1911191cf8c2b855268a76baf0757909d66d1b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@myankelev Pushed as commit 2a232d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.