8356779: IGV: dump the index of the SafePointNode containing the current JVMS during parsing

[sarannat]

This PR prints index of the SafePointNode containing the current JVMS during parsing in IGV. As stated in JBS the reason for this is that there are a lot of nodes during parsing, it would be nice to know what are the current nodes in the local slots or in the stack when looking at a graph.

IGV screenshot of before fix

IGV screenshot of after fix

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356779: IGV: dump the index of the SafePointNode containing the current JVMS during parsing (Enhancement - P4)

Reviewers

• Emanuel Peter (@eme64 - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)
• Quan Anh Mai (@merykitty - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27083/head:pull/27083
$ git checkout pull/27083

Update a local copy of the PR:
$ git checkout pull/27083
$ git pull https://git.openjdk.org/jdk.git pull/27083/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27083

View PR using the GUI difftool:
$ git pr show -t 27083

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27083.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back snatarajan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sarannat This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356779: IGV: dump the index of the SafePointNode containing the current JVMS during parsing

Reviewed-by: epeter, chagedorn, qamai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 547 new commits pushed to the master branch:

• faebec6: 8367532: Declare all stubgen stub entries including internal cross-stub entries
• 005f3a3: 8367743: G1: Use named constants for G1CSetCandidateGroup group ids
• 5730e90: 4138921: TextLayout handling of empty strings
• ... and 544 more: https://git.openjdk.org/jdk/compare/f95af744b07a9ec87e2507b3d584cbcddc827bbd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@eme64, @chhagedorn, @merykitty) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@sarannat The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (75c2d19b)

[eme64]

Looks reasonable.

@merykitty first proposed this, so would be good if he took a look too :)

[eme64]

Just out of curiosity: could you show a before/after igv screenshot?

[chhagedorn]

That's a good addition, looks good to me, too!

[sarannat]

Thanks for the review. Please sponsor.

[sarannat]

/integrate

[mhaessig]

/sponsor

[openjdk]

@sarannat
Your change (at version 75c2d19) is now ready to be sponsored by a Committer.

[openjdk]

Going to push as commit 6df0117.
Since your change was applied there have been 547 commits pushed to the master branch:

• faebec6: 8367532: Declare all stubgen stub entries including internal cross-stub entries
• 005f3a3: 8367743: G1: Use named constants for G1CSetCandidateGroup group ids
• 5730e90: 4138921: TextLayout handling of empty strings
• ... and 544 more: https://git.openjdk.org/jdk/compare/f95af744b07a9ec87e2507b3d584cbcddc827bbd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mhaessig @sarannat Pushed as commit 6df0117.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.