-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8264273: macOS: zero VM is broken due to no member named 'is_cpu_emulated' after JDK-8261966 #3216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ated' after JDK-8261966
/issue add JDK-8261966 |
👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into |
@DamonFool |
@DamonFool |
@DamonFool The |
/issue remove JDK-8261966 |
@DamonFool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@DamonFool This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
looks good and won't conflict with similar fix in just integrated jep-391 |
Thanks @iklam and @VladimirKempik for your review. |
@DamonFool Since your change was applied there have been 13 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 38e0a58. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Why is the member missing under a Zero build? Whether or not the CPU is emulated is a feature of the OS and the binary - the compiler/interpreter mode is not relevant. This looks like the wrong fix to me. |
VM_Version::is_cpu_emulated() seems to be also CPU-dependent since its implementations of x86 and aarch64 are different. Did you mean we should copy the aarch64's implementation for bsd_zero build? |
Mailing list message from David Holmes on hotspot-runtime-dev: On 29/03/2021 4:36 pm, Jie Fu wrote:
Whether a given CPU is emulated is a feature of the actual OS and CPU,
Hmmm. So zero pretends to be a CPU because it is CPU-agnostic when it So the build problem is resolved, but you can't run a zero x64 binary in Thanks, |
Hi all,
Zero VM on macOS is broken after JDK-8261966.
Let's fix it.
Thanks.
Best regards,
Jie
Progress
Issue
Reviewers
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3216/head:pull/3216
$ git checkout pull/3216
To update a local copy of the PR:
$ git checkout pull/3216
$ git pull https://git.openjdk.java.net/jdk pull/3216/head