New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8264727: Shenandoah: Remove extraneous whitespace from phase timings report #3342
8264727: Shenandoah: Remove extraneous whitespace from phase timings report #3342
Conversation
👋 Welcome back earthling-amzn! A progress list of the required criteria for merging this PR into |
@earthling-amzn The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Created: https://bugs.openjdk.java.net/browse/JDK-8264727 -- rename this PR to "8264727: Shenandoah: Remove extraneous whitespace from phase timings report" to get it hooked up. |
/integrate |
@earthling-amzn This PR has not yet been marked as ready for integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine and trivial.
/integrate |
@earthling-amzn This PR has not yet been marked as ready for integration. |
You need to resolve the integration blocker before integration: the PR title and bug synopsis are mismatched. You need "Shenandoah: " in the title. |
@earthling-amzn Still want to integrate this? You need to title this PR correctly for bots to catch it up. |
/integrate |
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 68 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@earthling-amzn |
/sponsor |
@shipilev @earthling-amzn Since your change was applied there have been 68 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit ec31b3a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This extra space doesn't look like it was intended to improve any alignment of text in the report.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3342/head:pull/3342
$ git checkout pull/3342
Update a local copy of the PR:
$ git checkout pull/3342
$ git pull https://git.openjdk.java.net/jdk pull/3342/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3342
View PR using the GUI difftool:
$ git pr show -t 3342
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3342.diff