Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264727: Shenandoah: Remove extraneous whitespace from phase timings report #3342

Conversation

@earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Apr 5, 2021

This extra space doesn't look like it was intended to improve any alignment of text in the report.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264727: Shenandoah: Remove extraneous whitespace from phase timings report

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3342/head:pull/3342
$ git checkout pull/3342

Update a local copy of the PR:
$ git checkout pull/3342
$ git pull https://git.openjdk.java.net/jdk pull/3342/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3342

View PR using the GUI difftool:
$ git pr show -t 3342

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3342.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 5, 2021

👋 Welcome back earthling-amzn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 5, 2021

@earthling-amzn The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Apr 5, 2021

Created: https://bugs.openjdk.java.net/browse/JDK-8264727 -- rename this PR to "8264727: Shenandoah: Remove extraneous whitespace from phase timings report" to get it hooked up.

@earthling-amzn earthling-amzn changed the title Remove extraneous whitespace from phase timings report 8264727: Remove extraneous whitespace from phase timings report Apr 5, 2021
@openjdk openjdk bot added the rfr label Apr 5, 2021
@earthling-amzn
Copy link
Contributor Author

@earthling-amzn earthling-amzn commented Apr 5, 2021

/integrate

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 5, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 5, 2021

@earthling-amzn This PR has not yet been marked as ready for integration.

Copy link
Contributor

@shipilev shipilev left a comment

Looks fine and trivial.

@earthling-amzn
Copy link
Contributor Author

@earthling-amzn earthling-amzn commented Apr 5, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 5, 2021

@earthling-amzn This PR has not yet been marked as ready for integration.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Apr 6, 2021

You need to resolve the integration blocker before integration: the PR title and bug synopsis are mismatched. You need "Shenandoah: " in the title.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Apr 9, 2021

@earthling-amzn Still want to integrate this? You need to title this PR correctly for bots to catch it up.

@earthling-amzn earthling-amzn changed the title 8264727: Remove extraneous whitespace from phase timings report 8264727: Shenandoah: Remove extraneous whitespace from phase timings report Apr 9, 2021
@earthling-amzn
Copy link
Contributor Author

@earthling-amzn earthling-amzn commented Apr 9, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264727: Shenandoah: Remove extraneous whitespace from phase timings report

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

  • cc54de7: 8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed
  • 6de0bb2: 8232861: (fc) FileChannel.force fails on WebDAV file systems (macOS)
  • 1ca4abe: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI
  • 06e6b1f: 8259242: Remove ProtectionDomainSet_lock
  • 9bb1863: 8260923: Add more tests for SSLSocket input/output shutdown
  • 33fa855: 8264732: Clean up LinkResolver::vtable_index_of_interface_method()
  • b3782ea: 8264918: [JVMCI] getVtableIndexForInterfaceMethod doesn't check that type and method are related
  • f7a6c63: 8259822: [PPC64] Support the prefixed instruction format added in POWER10
  • a45733f: 8264779: Fix doclint warnings in java/nio
  • 3e57924: 8264885: Fix the code style of macro in aarch64_neon_ad.m4
  • ... and 58 more: https://git.openjdk.java.net/jdk/compare/a0ec2cb289463969509fe508836e3faf789f46d8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@earthling-amzn
Your change (at version a18e517) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Apr 9, 2021

/sponsor

@openjdk openjdk bot closed this Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@shipilev @earthling-amzn Since your change was applied there have been 68 commits pushed to the master branch:

  • cc54de7: 8264400: (fs) WindowsFileStore equality depends on how the FileStore was constructed
  • 6de0bb2: 8232861: (fc) FileChannel.force fails on WebDAV file systems (macOS)
  • 1ca4abe: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI
  • 06e6b1f: 8259242: Remove ProtectionDomainSet_lock
  • 9bb1863: 8260923: Add more tests for SSLSocket input/output shutdown
  • 33fa855: 8264732: Clean up LinkResolver::vtable_index_of_interface_method()
  • b3782ea: 8264918: [JVMCI] getVtableIndexForInterfaceMethod doesn't check that type and method are related
  • f7a6c63: 8259822: [PPC64] Support the prefixed instruction format added in POWER10
  • a45733f: 8264779: Fix doclint warnings in java/nio
  • 3e57924: 8264885: Fix the code style of macro in aarch64_neon_ad.m4
  • ... and 58 more: https://git.openjdk.java.net/jdk/compare/a0ec2cb289463969509fe508836e3faf789f46d8...master

Your commit was automatically rebased without conflicts.

Pushed as commit ec31b3a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants