Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265381: ProblemList runtime/logging/RedefineClasses.java on macos-x64 -Xcomp #3552

Closed
wants to merge 1 commit into from

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Apr 16, 2021

A trivial change to ProblemList runtime/logging/RedefineClasses.java on macos-x64 -Xcomp.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265381: ProblemList runtime/logging/RedefineClasses.java on macos-x64 -Xcomp

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3552/head:pull/3552
$ git checkout pull/3552

Update a local copy of the PR:
$ git checkout pull/3552
$ git pull https://git.openjdk.java.net/jdk pull/3552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3552

View PR using the GUI difftool:
$ git pr show -t 3552

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3552.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 16, 2021

/label add hotspot-runtime
/label add hotspot-compiler

Loading

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Apr 16, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 16, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk
The hotspot-compiler label was successfully added.

Loading

bplb
bplb approved these changes Apr 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265381: ProblemList runtime/logging/RedefineClasses.java on macos-x64 -Xcomp

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 16, 2021

Webrevs

Loading

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 16, 2021

@bplb - Thanks for the fast review!

/integrate

Loading

@openjdk openjdk bot closed this Apr 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@dcubed-ojdk Pushed as commit 2c4075c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@dcubed-ojdk dcubed-ojdk deleted the JDK-8265381 branch Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants