8253543: sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java failed with "AssertionError: All pixels are not black"

[shurymury]

Added a few synchronization points to the test:
1 wait for the screen to change where the test window is displayed
2 wait for the image to get still (i.e. painted complete)
3 wait for the image to change after the mouse move
4 wait for the image change and then to get still after the mouse press
5 wait for the image to change after the mouse release

@mrserb Can you take a look?

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253543: sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java failed with "AssertionError: All pixels are not black"

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/389/head:pull/389
$ git checkout pull/389

[bridgekeeper]

👋 Welcome back shurailine! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shurymury The following label will be automatically applied to this pull request:

• swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (b45c19c)
• 00: Full (0f083b6)

[openjdk]

@shurymury This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253543: sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java failed with "AssertionError: All pixels are not black"

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 5310d85: 8252937: Correct "no comment" warnings from javadoc in java.math package
• 8df3e72: 8218685: jlink --list-plugins needs to be readable and tidy
• 2fe0a5d: 8253476: TestUseContainerSupport.java fails on some Linux kernels w/o swap limit capabilities
• fb20690: 8253637: Update EC removal
• b1ce6bd: 8253548: jvmFlagAccess.cpp: clang 9.0.0 format specifier error
• ff6843c: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
• d5be829: 8253770: Test tools/javac/parser/JavacParserTest.java fails on Windows after JDK-8253584
• 6e5d4f3: 8253607: [mlvm] meth/func/jdi/breakpointOtherStratum: un-problemlist and add randomness keyword
• 3ed960e: 8253640: Make MEMFLAGS an enum class
• 86491a5: 8253584: Redunant errors for partial member selects
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/d25b03e987396ef72534abc3c49bd7b53380a561...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shurymury]

/integrate

[openjdk]

@shurymury Since your change was applied there have been 21 commits pushed to the master branch:

• 5310d85: 8252937: Correct "no comment" warnings from javadoc in java.math package
• 8df3e72: 8218685: jlink --list-plugins needs to be readable and tidy
• 2fe0a5d: 8253476: TestUseContainerSupport.java fails on some Linux kernels w/o swap limit capabilities
• fb20690: 8253637: Update EC removal
• b1ce6bd: 8253548: jvmFlagAccess.cpp: clang 9.0.0 format specifier error
• ff6843c: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
• d5be829: 8253770: Test tools/javac/parser/JavacParserTest.java fails on Windows after JDK-8253584
• 6e5d4f3: 8253607: [mlvm] meth/func/jdi/breakpointOtherStratum: un-problemlist and add randomness keyword
• 3ed960e: 8253640: Make MEMFLAGS an enum class
• 86491a5: 8253584: Redunant errors for partial member selects
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/d25b03e987396ef72534abc3c49bd7b53380a561...master

Your commit was automatically rebased without conflicts.

Pushed as commit ffc97ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[amresh-sahu]

All changes look good.