-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8267937: Wrong indentation in G1 gc+phases log for free cset subphases #4249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267937: Wrong indentation in G1 gc+phases log for free cset subphases #4249
Conversation
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@tschatzl This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
|
Thanks @albertnetymk @kstefanj for your reviews. /integrate |
@tschatzl Since your change was applied there have been 27 commits pushed to the
|
Hi all,
JDK-8214327: Join parallel phases post evacuation messed up some indentation of logging:
The current gc+phases=trace looks as follows:
Young Free Collection Set
andNon-Young Free Collection set
are indented one level too many.This change fixes this.
Testing: manual testing, there is no indentation check for log messages
Thanks,
Thomas
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4249/head:pull/4249
$ git checkout pull/4249
Update a local copy of the PR:
$ git checkout pull/4249
$ git pull https://git.openjdk.java.net/jdk pull/4249/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4249
View PR using the GUI difftool:
$ git pr show -t 4249
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4249.diff