Skip to content

8269685: Optimize HeapHprofBinWriter implementation #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

8269685: Optimize HeapHprofBinWriter implementation #4666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a85d6b9
8269685: Optimize HeapHprofBinWriter implementation
linzang Jun 23, 2021
e5ef8bd
Merge branch 'master' into hprof
linzang Jul 5, 2021
59691b5
fix write size issue
linzang Jul 5, 2021
cb1cbeb
Merge branch 'master' into hprof
Aug 13, 2021
7b2a964
code clean up and remove useless methods
linzang Aug 24, 2021
32e6b4c
make calculateGlobalJNIHandlesDumpRecordSize abstract
linzang Aug 24, 2021
e8b7858
Merge branch 'master' into hprof
linzang Sep 6, 2021
20267f6
code clean up and refinement
Sep 16, 2021
ec20fba
Merge branch 'master' into hprof
Sep 16, 2021
de20431
code refine
Sep 17, 2021
6b7dba5
code refine
linzang Sep 24, 2021
1da3ab1
Merge branch 'master' into hprof
linzang Sep 24, 2021
db854e9
code refine
Sep 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/AbstractHeapGraphWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public void prologue(long usedSize) {

public boolean doObj(Oop oop) {
try {
writeHeapRecordPrologue();
writeHeapRecordPrologue(calculateOopDumpRecordSize(oop));
if (oop instanceof TypeArray) {
writePrimitiveArray((TypeArray)oop);
} else if (oop instanceof ObjArray) {
Expand Down Expand Up @@ -127,6 +127,8 @@ public void epilogue() {
}
}

abstract protected int calculateOopDumpRecordSize(Oop oop) throws IOException;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Lin,
I don't like these empty methods in this abstract class.
Should they be just abstract instead?
Thanks,
Serguei

protected void writeJavaThreads() throws IOException {
Threads threads = VM.getVM().getThreads();
for (int i = 0; i < threads.getNumberOfThreads(); i++) {
Expand Down Expand Up @@ -420,6 +422,9 @@ protected void writeHeapFooter() throws IOException {
protected void writeHeapRecordPrologue() throws IOException {
}

protected void writeHeapRecordPrologue(int size) throws IOException {
}

protected void writeHeapRecordEpilogue() throws IOException {
}

Expand Down
5 changes: 5 additions & 0 deletions src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapGXLWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,11 @@ protected void writeHeapFooter() throws IOException {
out.println("</gxl>");
}

@Override
protected int calculateOopDumpRecordSize(Oop oop) throws IOException {
return 0;
}

//-- Internals only below this point

// Java identifier to XML NMTOKEN type string
Expand Down
Loading