8253459: Formatter treats index, width and precision > Integer.MAX_VALUE incorrectly #516
I've been on the fence about this, personally. The Formatter uses pretty fine-grained exception types for error conditions. I'd be okay discontinuing this practice here, but am not sure what to replace this with. Perhaps we enable
Should IllegalFormatArgumentIndexException.java provide an override of getMessage? It appears that is done in the following:
Otherwise the index won't be rendered when toString or printStackTrace is invoked.
Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
Stats: 18 lines in 2 files changed: 0 ins; 5 del; 13 mod
@igraves This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 87 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs, @stuart-marks) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type
Your commit was automatically rebased without conflicts.
Pushed as commit 080c707.
💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.
…LUE incorrectly Reviewed-by: rriggs, smarks