Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249623: test @ignore-d due to 7013634 should be returned back to execution #551

Closed
wants to merge 1 commit into from
Closed

8249623: test @ignore-d due to 7013634 should be returned back to execution #551

wants to merge 1 commit into from

Conversation

@alexmenkov
Copy link

@alexmenkov alexmenkov commented Oct 7, 2020

  • updated timeout/stressTime for resexhausted001 test so on Windows we get "can't reproduce OOME" instead of timeout;
  • updated resexhausted001 cleanup code (to terminate all threads);
  • intermittent resexhausted001 failure on linux is problem-listed;
  • updated resexhausted001 and resexhausted002 to throw SkippedException if OOM is not thrown

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/551/head:pull/551
$ git checkout pull/551

…cution

- updated timeout/stressTime for resexhausted001 test so on Windows we get "can't reproduce OOME" instead of timeout;
- updated resexhausted001 cleanup code (to terminate all threads);
- intermittent resexhausted001 failure on linux is problem-listed;
- updated resexhausted001 and resexhausted002 to throw SkippedException if OOM is not thrown
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 8, 2020

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2020

@alexmenkov The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 8, 2020

Webrevs

Loading

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Oct 13, 2020

Ping

Loading

Copy link
Contributor

@plummercj plummercj left a comment

Looks good.

Loading

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Hi Alex,
Looks good.
Thanks,
Serguei

Loading

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Oct 14, 2020

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@alexmenkov This PR has not yet been marked as ready for integration.

Loading

@alexmenkov alexmenkov changed the title 8249623: test @ignore-d due to 7013634 should be returned back to exe… 8249623: test @ignore-d due to 7013634 should be returned back to execution Oct 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8249623: test @ignore-d due to 7013634 should be returned back to execution

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 122 new commits pushed to the master branch:

  • b7daf84: 8254345: com/sun/jdi/JdwpAttachTest.java reports error incorrectly
  • fde02e2: 8254012: NMT: MetaspaceSnapshot::snapshot uses wrong enum
  • 96a1f08: 8254775: Microbenchmark StringIndexOfChar doesn't compile
  • a6a3813: 8254761: Wrong intrinsic annotation used for StringLatin1.indexOfChar
  • 738effa: 8254744: Clean-up CodeBlob::align_code_offset
  • f71e8a6: 8173585: Intrinsify StringLatin1.indexOf(char)
  • 95e68c6: 8254586: Replace fthrow() calls with simpler method calls in classFileParser.cpp
  • ba140b0: 8254748: Bad Copyright header format after JDK-8212218
  • db9dcdf: 8254668: JVMTI process frames on thread without started processing
  • dc262df: 8212218: [TESTBUG] runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryErrorInMetaspace.java timed out
  • ... and 112 more: https://git.openjdk.java.net/jdk/compare/ac772cd91632f16efad4ce92b7518c282ce0cfad...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 14, 2020
@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Oct 14, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@alexmenkov Since your change was applied there have been 122 commits pushed to the master branch:

  • b7daf84: 8254345: com/sun/jdi/JdwpAttachTest.java reports error incorrectly
  • fde02e2: 8254012: NMT: MetaspaceSnapshot::snapshot uses wrong enum
  • 96a1f08: 8254775: Microbenchmark StringIndexOfChar doesn't compile
  • a6a3813: 8254761: Wrong intrinsic annotation used for StringLatin1.indexOfChar
  • 738effa: 8254744: Clean-up CodeBlob::align_code_offset
  • f71e8a6: 8173585: Intrinsify StringLatin1.indexOf(char)
  • 95e68c6: 8254586: Replace fthrow() calls with simpler method calls in classFileParser.cpp
  • ba140b0: 8254748: Bad Copyright header format after JDK-8212218
  • db9dcdf: 8254668: JVMTI process frames on thread without started processing
  • dc262df: 8212218: [TESTBUG] runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryErrorInMetaspace.java timed out
  • ... and 112 more: https://git.openjdk.java.net/jdk/compare/ac772cd91632f16efad4ce92b7518c282ce0cfad...master

Your commit was automatically rebased without conflicts.

Pushed as commit cd33abb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@alexmenkov alexmenkov deleted the resexhausted001 branch Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants