New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278071: typos in MemorySegment::set, MemorySegment::setAtIndex javadoc #6635
Conversation
|
@mcimadamore The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivial fix for an apparent cut-and-paste error.
@mcimadamore This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 70 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
Going to push as commit 16cfbc4.
Your commit was automatically rebased without conflicts. |
@mcimadamore Pushed as commit 16cfbc4. |
There are some truncated statements in MemorySegment::get/MemorySegment::getAtIndex javadoc, more specifically in the
@throws
forIndexOutOfBoundsException
.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6635/head:pull/6635
$ git checkout pull/6635
Update a local copy of the PR:
$ git checkout pull/6635
$ git pull https://git.openjdk.java.net/jdk pull/6635/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6635
View PR using the GUI difftool:
$ git pr show -t 6635
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6635.diff