8254789: ProblemList compiler/graalunit/HotspotTest.java

[dcubed-ojdk]

This is a trivial change to ProblemList compiler/graalunit/HotspotTest.java.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8254789: ProblemList compiler/graalunit/HotspotTest.java

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer) ⚠️ Review applies to 8b01c7c
• Igor Ignatyev (@iignatev - Reviewer) ⚠️ Review applies to 4cafa5b
• Vladimir Kozlov (@vnkozlov - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/666/head:pull/666
$ git checkout pull/666

[dcubed-ojdk]

/label add hotspot-runtime
/label add hotspot-compiler

[bridgekeeper]

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[iignatev]

@dcubed-ojdk
graal unit tests can be excluded individually by adding entries to ProblemList-graal.txt :

diff --git a/test/hotspot/jtreg/ProblemList-graal.txt b/test/hotspot/jtreg/ProblemList-graal.txt 
index f73a4883f42..634f2bc12f6 100644 
--- a/test/hotspot/jtreg/ProblemList-graal.txt 
+++ b/test/hotspot/jtreg/ProblemList-graal.txt 
@@ -239,3 +239,5 @@ org.graalvm.compiler.replacements.test.classfile.ClassfileBytecodeProviderTest 
 org.graalvm.compiler.core.test.deopt.CompiledMethodTest 8202955 
  
 org.graalvm.compiler.hotspot.test.ReservedStackAccessTest 8213567 windows-all 
+ 
+org.graalvm.compiler.hotspot.test.CheckGraalIntrinsics 8254785

[openjdk]

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254789: ProblemList compiler/graalunit/HotspotTest.java

Reviewed-by: rriggs, iignatyev, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dcubed-ojdk
The hotspot-runtime label was successfully added.

[dcubed-ojdk]

@iignatev - I forgot about that file!

[openjdk]

@dcubed-ojdk
The hotspot-compiler label was successfully added.

[mlbridge]

Webrevs

• 02: Full - Incremental (869576d)
• 01: Full - Incremental (4cafa5b)
• 00: Full (8b01c7c)

[dcubed-ojdk]

@iignatev - should be fixed now.
@RogerRiggs - can you also re-review?

[iignatev]

LGTM. but, in JBS, @vnkozlov said that it's easy to fix the test, and he is working on the fix, so depending on the timing we might want to skip this one.

[dcubed-ojdk]

Hold on. I somehow lost the platform part of the entry.

[iignatev]

Hold on. I somehow lost the platform part of the entry.

you don't need it, and IIRC, it's not actually read by compiler.graalunit.common.GraalUnitTestLauncher

[dcubed-ojdk]

Okay. I added it anyway since the previous entry had it...

[dcubed-ojdk]

I want to integrate this ProblemListing to get the noise down.

[vnkozlov]

LGTM. but, in JBS, @vnkozlov said that it's easy to fix the test, and he is working on the fix, so depending on the timing we might want to skip this one.

I am fine with problem list the test first. Especially if you can list only CheckGraalIntrinsics. I am also inclining to do it permanently for time in JDK. I am tired to fix it each time people push new intrinsic. It gives us (JPG) nothing.

[dcubed-ojdk]

@RogerRiggs, @iignatev and @vnkozlov - Thanks for the fast reviews and
the help with getting this right.

/integrate

[openjdk]

@dcubed-ojdk Pushed as commit 386e7e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.