Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254982: (tz) Upgrade time-zone data to tzdata2020c #747

Closed
wants to merge 3 commits into from

Conversation

kiranoracle
Copy link

@kiranoracle kiranoracle commented Oct 19, 2020

Hi Guys,

Please review the integration of tzdata2020c to JDK.

Details regarding the change can be viewed at - https://mm.icann.org/pipermail/tz-announce/2020-October/000060.html
Bug: https://bugs.openjdk.java.net/browse/JDK-8254982

Along with it, there is a test fix for https://bugs.openjdk.java.net/browse/JDK-8254865, With tzdata2020b, the test fails for the mentioned zones expecting "PST" but JDK has Zone names for "MST" for JRE locale provider. Since the purpose of the test is to get any GMT-08:00 time zone, I have excluded those zones from the test.

Please let me know if the changes are good to push.

Thanks,
Kiran


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254982: (tz) Upgrade time-zone data to tzdata2020c

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/747/head:pull/747
$ git checkout pull/747

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2020

👋 Welcome back kravikumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2020
@openjdk
Copy link

openjdk bot commented Oct 19, 2020

@kiranoracle The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Oct 19, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2020

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Build change looks ok.

@openjdk
Copy link

openjdk bot commented Oct 19, 2020

@kiranoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254982: (tz) Upgrade time-zone data to tzdata2020c

Reviewed-by: erikj, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 91 new commits pushed to the master branch:

  • 0e92053: 8254286: Wrong inference in switch expression with "null" arm
  • 63ce304: 8249675: x86: frequency extraction from cpu brand string is incomplete
  • e52156d: 8255067: Restore Copyright line in file modified by 8253191
  • c520469: 8255131: G1CollectedHeap::is_in() returns wrong result
  • 107fb9c: 8255049: Remove support for the hsdis decode_instructions entry point in hotspot
  • c1524c5: 8255208: CodeStrings passed to Disassembler::decode are ignored
  • 8e5dff0: 8255213: Shenandoah build fails without JFR after JDK-8255036
  • fe74f3c: 8255224: x86_32 tests fail with "bad AD file" after JDK-8223051
  • 64dc4b1: 8255225: compiler/aot tests fail on Windows with NPE during artifact resolution
  • a824781: 8255210: [Vector API] jdk/incubator/vector/Int256VectorTests.java crashes on AVX512 machines
  • ... and 81 more: https://git.openjdk.java.net/jdk/compare/3ee0380e99efafbfbb5b75f0c7664095a568fda4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2020
list.remove("America/Dawson");
list.remove("America/WhiteHorse");
list.remove("Canada/Yukon");
Copy link
Member

@naotoj naotoj Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd explicitly mention why these time zones are removed from the test.

Copy link
Author

@kiranoracle kiranoracle Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Naoto, I have added the information.

naotoj
naotoj approved these changes Oct 20, 2020
Copy link
Member

@naotoj naotoj left a comment

Looks good. Thank you for the changes.

@kiranoracle
Copy link
Author

kiranoracle commented Oct 20, 2020

/reviewer credit @naotoj

@openjdk
Copy link

openjdk bot commented Oct 20, 2020

@kiranoracle Reviewer naoto has already made an authenticated review of this PR, and does not need to be credited manually.

@openjdk openjdk deleted a comment from openjdk bot Oct 20, 2020
@openjdk openjdk deleted a comment from openjdk bot Oct 21, 2020
@kiranoracle
Copy link
Author

kiranoracle commented Oct 23, 2020

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 23, 2020
@openjdk
Copy link

openjdk bot commented Oct 23, 2020

@kiranoracle
Your change (at version 7434663) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Oct 23, 2020

/sponsor

@openjdk openjdk bot closed this Oct 23, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 23, 2020
@openjdk
Copy link

openjdk bot commented Oct 23, 2020

@coffeys @kiranoracle Since your change was applied there have been 92 commits pushed to the master branch:

  • ac1748e: 8254670: SVE test uses linux-specific api
  • 0e92053: 8254286: Wrong inference in switch expression with "null" arm
  • 63ce304: 8249675: x86: frequency extraction from cpu brand string is incomplete
  • e52156d: 8255067: Restore Copyright line in file modified by 8253191
  • c520469: 8255131: G1CollectedHeap::is_in() returns wrong result
  • 107fb9c: 8255049: Remove support for the hsdis decode_instructions entry point in hotspot
  • c1524c5: 8255208: CodeStrings passed to Disassembler::decode are ignored
  • 8e5dff0: 8255213: Shenandoah build fails without JFR after JDK-8255036
  • fe74f3c: 8255224: x86_32 tests fail with "bad AD file" after JDK-8223051
  • 64dc4b1: 8255225: compiler/aot tests fail on Windows with NPE during artifact resolution
  • ... and 82 more: https://git.openjdk.java.net/jdk/compare/3ee0380e99efafbfbb5b75f0c7664095a568fda4...master

Your commit was automatically rebased without conflicts.

Pushed as commit 55a0cad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
4 participants