-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282170: JVMTI SetBreakpoint metaspace allocation test #7554
8282170: JVMTI SetBreakpoint metaspace allocation test #7554
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
Webrevs
|
So you load a class 50 times in separate ClassLoaders, and each load triggers the ClassPrepare event, and each time that happens you set a breakpoint on each of the 1000 methods, meaning a total of 5000 breakpoints. Doing this will eventually trigger calling CollectorPolicy::satisfy_failed_metadata_allocation(). Previous to the 8264149 fix, this used to trigger an assert. Am I understanding this properly? |
Yes. That assert is actually the part of the larger issue: metaspace is full, GC is requested, and VM would probably hang if we allow it to happen, since we cannot easily schedule Full GCs when already at safepoint. |
test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/TestManyBreakpoints.java
Outdated
Show resolved
Hide resolved
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 29 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks @plummercj! Anyone else to review? |
Friendly reminder. |
test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/TestManyBreakpoints.java
Outdated
Show resolved
Hide resolved
test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/libTestManyBreakpoints.c
Outdated
Show resolved
Hide resolved
test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/libTestManyBreakpoints.c
Outdated
Show resolved
Hide resolved
I also rewritten the test to use bundled ASM instead of long target class. This also allows bumping the number of methods in the target without adding a lot of new lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for fixing
Not a review yet but I'd suggest to convert .c to .cpp. |
Good thinking. I converted the test to C++, and this also allowed to simplify the JNI/JVMTI calls a bit. |
@lmesnik, @plummercj -- please re-ack the new version, thanks. |
Thanks! /integrate |
Going to push as commit 7b91bbb.
Your commit was automatically rebased without conflicts. |
There are few bugs in SetBreakpoint when it reaches for metaspace allocation, notably JDK-8214992 and JDK-8264149. This adds the test that exercises the metaspace allocation paths.
Requires JDK-8282172 to pass cleanly in fastdebug mode.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7554/head:pull/7554
$ git checkout pull/7554
Update a local copy of the PR:
$ git checkout pull/7554
$ git pull https://git.openjdk.java.net/jdk pull/7554/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7554
View PR using the GUI difftool:
$ git pr show -t 7554
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7554.diff