-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282402: Create a test for checking the effect of down arrow after adding text on a line preceding a blank line #7623
Conversation
👋 Welcome back mvs! A progress list of the required criteria for merging this PR into |
@manukumarvs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@aivanov-jdk Can you please review this. |
@manukumarvs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 192 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@manukumarvs |
… removed casting for jEditorLoc.x
/integrate |
@manukumarvs |
/sponsor |
Going to push as commit 1581e3f.
Your commit was automatically rebased without conflicts. |
@aivanov-jdk @manukumarvs Pushed as commit 1581e3f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Create a regression test for JDK-4666101.
DESCRIPTION OF THE ACTUAL PROBLEM :
In a JEditorPane, the down arrow has no effect after you add text on a line preceding a blank line.
Testing:
As the original issue was reported in JDK 1.4.0 and it was fixed in JDK 1.4.2, I have verified the working of this test in those Java versions and the results are as follows:
Java 1.4.0 -> Test Failed.
$ ./j2sdk1.4.0/bin/java JEditorBugWin
Caret Updated : 3
Test Failed, Down Arrow Key Not Functional, expected caret position is 5, but actual is 4
Java 1.4.2 -> Test Passed.
$ ./j2sdk1.4.2/bin/java JEditorBugWin
Caret Updated : 5
Test Passed, Down Arrow Key Functional
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7623/head:pull/7623
$ git checkout pull/7623
Update a local copy of the PR:
$ git checkout pull/7623
$ git pull https://git.openjdk.java.net/jdk pull/7623/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 7623
View PR using the GUI difftool:
$ git pr show -t 7623
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7623.diff