Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282402: Create a test for checking the effect of down arrow after adding text on a line preceding a blank line #7623

Closed
wants to merge 4 commits into from

Conversation

manukumarvs
Copy link
Member

@manukumarvs manukumarvs commented Feb 25, 2022

Create a regression test for JDK-4666101.

DESCRIPTION OF THE ACTUAL PROBLEM :
In a JEditorPane, the down arrow has no effect after you add text on a line preceding a blank line.

Testing:
As the original issue was reported in JDK 1.4.0 and it was fixed in JDK 1.4.2, I have verified the working of this test in those Java versions and the results are as follows:

Java 1.4.0 -> Test Failed.
$ ./j2sdk1.4.0/bin/java JEditorBugWin
Caret Updated : 3
Test Failed, Down Arrow Key Not Functional, expected caret position is 5, but actual is 4

Java 1.4.2 -> Test Passed.
$ ./j2sdk1.4.2/bin/java JEditorBugWin
Caret Updated : 5
Test Passed, Down Arrow Key Functional


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282402: Create a regression test for JDK-4666101

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7623/head:pull/7623
$ git checkout pull/7623

Update a local copy of the PR:
$ git checkout pull/7623
$ git pull https://git.openjdk.java.net/jdk pull/7623/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7623

View PR using the GUI difftool:
$ git pr show -t 7623

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7623.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 25, 2022

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 25, 2022
@openjdk
Copy link

openjdk bot commented Feb 25, 2022

@manukumarvs The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Feb 25, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 25, 2022

Webrevs

@manukumarvs
Copy link
Member Author

@aivanov-jdk Can you please review this.

@openjdk
Copy link

openjdk bot commented Mar 3, 2022

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282402: Create a regression test for JDK-4666101

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 192 new commits pushed to the master branch:

  • c777bb3: 8282619: G1: Fix indentation in G1CollectedHeap::mark_evac_failure_object
  • 080baff: 8282483: Ensure that Utils.getAllInterfaces returns unique instances
  • 57020fd: 8282582: Unused methods in Utils
  • 5c187e3: 8282593: JDK-8281472 breaks 32-bit builds and gtests
  • 7822cbc: 8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint
  • 832729b: 6911375: mouseWheel has no effect without vertical scrollbar
  • 0402a28: 8037965: NullPointerException in TextLayout.getBaselineFromGraphic() for JTextComponents
  • d4d1fbc: 8282484: G1: Predicted old time in log always zero
  • b1f935c: 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics
  • 2da6777: 8281122: [IR Framework] Cleanup IR matching code in preparation for JDK-8280378
  • ... and 182 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 3, 2022
@manukumarvs
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 3, 2022
@openjdk
Copy link

openjdk bot commented Mar 3, 2022

@manukumarvs
Your change (at version 5dec2a8) is now ready to be sponsored by a Committer.

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Mar 3, 2022
@manukumarvs
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 3, 2022
@openjdk
Copy link

openjdk bot commented Mar 3, 2022

@manukumarvs
Your change (at version dc26ec2) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 3, 2022

Going to push as commit 1581e3f.
Since your change was applied there have been 193 commits pushed to the master branch:

  • 268fa69: 8282511: Use fixed certificate validation date in SSLExampleCert template
  • c777bb3: 8282619: G1: Fix indentation in G1CollectedHeap::mark_evac_failure_object
  • 080baff: 8282483: Ensure that Utils.getAllInterfaces returns unique instances
  • 57020fd: 8282582: Unused methods in Utils
  • 5c187e3: 8282593: JDK-8281472 breaks 32-bit builds and gtests
  • 7822cbc: 8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint
  • 832729b: 6911375: mouseWheel has no effect without vertical scrollbar
  • 0402a28: 8037965: NullPointerException in TextLayout.getBaselineFromGraphic() for JTextComponents
  • d4d1fbc: 8282484: G1: Predicted old time in log always zero
  • b1f935c: 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics
  • ... and 183 more: https://git.openjdk.java.net/jdk/compare/f07b8165231799383303e5c0755d07afd2feb7fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 3, 2022
@openjdk openjdk bot closed this Mar 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 3, 2022
@openjdk
Copy link

openjdk bot commented Mar 3, 2022

@aivanov-jdk @manukumarvs Pushed as commit 1581e3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@manukumarvs manukumarvs deleted the 8282402 branch May 4, 2022 07:48
@manukumarvs manukumarvs changed the title 8282402: Create a regression test for JDK-4666101 8282402: Create a test for checking the effect of down arrow after adding text on a line preceding a blank line Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants