Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249592 : Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode #7736

Closed

Conversation

rajamah
Copy link
Member

@rajamah rajamah commented Mar 7, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/7736/head:pull/7736
$ git checkout pull/7736

Update a local copy of the PR:
$ git checkout pull/7736
$ git pull https://git.openjdk.java.net/jdk pull/7736/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7736

View PR using the GUI difftool:
$ git pr show -t 7736

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/7736.diff

…lay scale varies and Java runs in DPI Unaware mode
…lay scale varies and Java runs in DPI Unaware mode
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2022

👋 Welcome back rajamah! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 7, 2022

@rajamah The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added client client-libs-dev@openjdk.org rfr Pull request is ready for review labels Mar 7, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 9, 2022

@rajamah This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode

Reviewed-by: serb, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

  • 70318e1: 8282884: Provide OID aliases for MD2, MD5, and OAEP
  • 6d8d156: 8280494: (D)TLS signature schemes
  • 5df2a05: 8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig()
  • d07f7c7: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • 31ad80a: 8280902: ResourceBundle::getBundle may throw NPE when invoked by JNI code with no caller frame
  • 12693a6: 8282432: Optimize masked "test" Vector API with predicate feature
  • 4924513: 8265263: AArch64: Combine vneg with right shift count
  • ea19114: 8282832: Update file path for HostnameMatcher/cert5.crt in test sun/security/util/Pem/encoding.sh
  • 72e987e: 7192189: Support endpoint identification algorithm in RFC 6125
  • 288d1af: 8282715: typo compileony in test Test8005033.java
  • ... and 47 more: https://git.openjdk.java.net/jdk/compare/fb6b929e6e935baeccfd03a7fbc048cc8b531ce5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 9, 2022
@rajamah
Copy link
Member Author

rajamah commented Mar 9, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 9, 2022
@openjdk
Copy link

openjdk bot commented Mar 9, 2022

@rajamah
Your change (at version 0c6c521) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Mar 10, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 10, 2022

Going to push as commit 8aba4de.
Since your change was applied there have been 58 commits pushed to the master branch:

  • ff76620: 8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default
  • 70318e1: 8282884: Provide OID aliases for MD2, MD5, and OAEP
  • 6d8d156: 8280494: (D)TLS signature schemes
  • 5df2a05: 8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig()
  • d07f7c7: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • 31ad80a: 8280902: ResourceBundle::getBundle may throw NPE when invoked by JNI code with no caller frame
  • 12693a6: 8282432: Optimize masked "test" Vector API with predicate feature
  • 4924513: 8265263: AArch64: Combine vneg with right shift count
  • ea19114: 8282832: Update file path for HostnameMatcher/cert5.crt in test sun/security/util/Pem/encoding.sh
  • 72e987e: 7192189: Support endpoint identification algorithm in RFC 6125
  • ... and 48 more: https://git.openjdk.java.net/jdk/compare/fb6b929e6e935baeccfd03a7fbc048cc8b531ce5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2022
@openjdk openjdk bot closed this Mar 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 10, 2022
@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@mrserb @rajamah Pushed as commit 8aba4de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants