Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277517: Bump minimum boot jdk to JDK 18 #8102

Closed
wants to merge 2 commits into from

Conversation

vidmik
Copy link
Contributor

@vidmik vidmik commented Apr 5, 2022

With the JDK 18 GA out it's time to bump the minimum boot JDK version for mainline/JDK 19.

Testing: tier1-5, GHA builds


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8102/head:pull/8102
$ git checkout pull/8102

Update a local copy of the PR:
$ git checkout pull/8102
$ git pull https://git.openjdk.java.net/jdk pull/8102/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8102

View PR using the GUI difftool:
$ git pr show -t 8102

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8102.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2022

👋 Welcome back mikael! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 5, 2022

@vidmik The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Apr 5, 2022
@vidmik vidmik changed the title WIP: 8277517: Bump minimum boot jdk to JDK 18 8277517: Bump minimum boot jdk to JDK 18 Apr 5, 2022
@openjdk openjdk bot added the rfr label Apr 5, 2022
jddarcy
jddarcy approved these changes Apr 5, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 5, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 5, 2022

@vidmik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277517: Bump minimum boot jdk to JDK 18

Reviewed-by: darcy, erikj, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 5, 2022
erikj79
erikj79 approved these changes Apr 5, 2022
@vidmik
Copy link
Contributor Author

vidmik commented Apr 5, 2022

Adding a random comment here in the hopes that it will generate an email and give everybody a chance to react to this change.

@vidmik
Copy link
Contributor Author

vidmik commented Apr 6, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 6, 2022

Going to push as commit 46ce2ef.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 77388ea: 8284368: Remove finalizer method in jdk.crypto.cryptoki
  • 8e4fab0: 8284303: runtime/Thread/AsyncExceptionTest.java timed out

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 6, 2022
@openjdk openjdk bot closed this Apr 6, 2022
@openjdk openjdk bot removed ready rfr labels Apr 6, 2022
@openjdk
Copy link

openjdk bot commented Apr 6, 2022

@vidmik Pushed as commit 46ce2ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
4 participants