Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250588: Shenandoah: LRB needs to save/restore fp registers for runtime call #105

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 7, 2021

Unclean backport, because Shenandoah LRB-native is not present in 11u (was added later to support concurrent weak roots).

Additional testing:

  • Linux x86_64 fastdebug hotspot_gc_shenandoah

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8250588: Shenandoah: LRB needs to save/restore fp registers for runtime call

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/105/head:pull/105
$ git checkout pull/105

Update a local copy of the PR:
$ git checkout pull/105
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/105/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 105

View PR using the GUI difftool:
$ git pr show -t 105

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/105.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3a8a15b5d005d30ba4a7109a8e91e3e6b72b885c 8250588: Shenandoah: LRB needs to save/restore fp registers for runtime call Jul 7, 2021
@openjdk
Copy link

openjdk bot commented Jul 7, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 7, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 7, 2021

Webrevs

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jul 7, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8250588: Shenandoah: LRB needs to save/restore fp registers for runtime call

Reviewed-by: zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 1d204c5: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*)
  • c1deb0c: 8213922: fix ctw stand-alone build

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2021
@shipilev
Copy link
Member Author

shipilev commented Jul 8, 2021

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 8, 2021

Going to push as commit bdf8568.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 1d204c5: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*)
  • c1deb0c: 8213922: fix ctw stand-alone build

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2021
@openjdk
Copy link

openjdk bot commented Jul 8, 2021

@shipilev Pushed as commit bdf8568.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8250588 branch Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants