-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8270947: AArch64: C1: use zero_words to initialize all objects #1502
Conversation
👋 Welcome back xliu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Hi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3-patch bundle passes tier1. Lgtm.
Pre-submit failure looks to be an infrastructure issue.
@navyxliu This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Hi, @GoeLin Those two fixed compilation issues for other variants. For item-1, I can reproduce it in jdk11u. The backport is trivial. I will append it to the Stack PRs. for item-2, I can't reproduce it! it's because current jdk11u can't build variant 'core'.
I would like to sideline 8280234 for time being. if variant core matters to jdk11u, I will seek to fix build core first. what do you think? |
I filed an issue about the build failure of variant=core. |
There may be an existing JBS issue patch that fixes the problem. |
Yes, I think JDK-8235673 can fix this build issue, but it isn't trivial. |
I took a look at JDK-8235673 and agree. Better to do the minimum fix you propose in JDK-8296502. |
We would like to backport JDK-8270947 to jdk11u. It's not only less code to maintain, but also better generated code. C1 can leverage DC ZVA in large allocations on aarch64. The secondary consideration is that openjdk11u aligns with oraclejdk11u.
This isn't a clean backport. Small cosmetic changes are made in
MacroAssembler::zero_words(Register ptr, Register cnt)
chunk.There are also 3 trailing bugfixes. We will post them together as stacked PRs
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1502/head:pull/1502
$ git checkout pull/1502
Update a local copy of the PR:
$ git checkout pull/1502
$ git pull https://git.openjdk.org/jdk11u-dev pull/1502/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1502
View PR using the GUI difftool:
$ git pr show -t 1502
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1502.diff