Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311081: KeytoolReaderP12Test.java fail on localized Windows platform #2479

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Jan 23, 2024

Backport of JDK-8311081

Testing

  • Local: Not applicable
    • jtreg message: Not a test or directory containing tests: java/security/KeyStore/PKCS12/Utils.java
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-01-25,26

Progress

  • Change must not contain extraneous whitespace
  • JDK-8311081 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8311081: KeytoolReaderP12Test.java fail on localized Windows platform (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2479/head:pull/2479
$ git checkout pull/2479

Update a local copy of the PR:
$ git checkout pull/2479
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2479/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2479

View PR using the GUI difftool:
$ git pr show -t 2479

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2479.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b4b2fecb42d9f14d73e8d79a9e59dee4d697f9cf 8311081: KeytoolReaderP12Test.java fail on localized Windows platform Jan 23, 2024
@openjdk
Copy link

openjdk bot commented Jan 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 23, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 23, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 23, 2024

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Jan 27, 2024

/approval request “Backporting for parity with jdk 11.0.23-oracle. No risk, test fix. Clean backport. SAP nightlies passed on 2024-01-25,26”

@openjdk
Copy link

openjdk bot commented Jan 27, 2024

@amosshi
8311081: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 27, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8311081: KeytoolReaderP12Test.java fail on localized Windows platform

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 26d795d: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"
  • 82a1501: 8324659: GHA: Generic jtreg errors are not reported
  • b4f6177: 8315761: Open source few swing JList and JMenuBar tests
  • fbc6005: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
  • ec4e75d: 8308245: Add -proc:full to describe current default annotation processing policy
  • bee8d32: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly
  • d3675a0: 8253739: java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java fails
  • 3f42f4c: 8244679: JVM/TI GetCurrentContendedMonitor/contmon001 failed due to "(IsSameObject#3) unexpected monitor object: 0x000000562336DBA8"
  • 6e850f3: 8310238: [test bug] javax/swing/JTableHeader/6889007/bug6889007.java fails
  • 1c12d16: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/03cd88522ed4af7d0c008abd6dedf70ddd37e253...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 29, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Jan 29, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@amosshi
Your change (at version 41debd8) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Jan 30, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 30, 2024

Going to push as commit 3a0c820.
Since your change was applied there have been 17 commits pushed to the master branch:

  • b1bdadd: 8315600: Open source few more headless Swing misc tests
  • 34ea901: 8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
  • c97f19a: 8272552: mark hotspot runtime/cds tests which ignore external VM flags
  • a4d416e: 8272335: runtime/cds/appcds/MoveJDKTest.java doesn't check exit codes
  • c9a30d0: 8246222: Rename javac test T6395981.java to be more informative
  • 6360095: 8315034: File.mkdirs() occasionally fails to create folders on Windows shared folder
  • 26d795d: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"
  • 82a1501: 8324659: GHA: Generic jtreg errors are not reported
  • b4f6177: 8315761: Open source few swing JList and JMenuBar tests
  • fbc6005: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
  • ... and 7 more: https://git.openjdk.org/jdk11u-dev/compare/03cd88522ed4af7d0c008abd6dedf70ddd37e253...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2024
@openjdk openjdk bot closed this Jan 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@GoeLin @amosshi Pushed as commit 3a0c820.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8311081 branch February 1, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants