-
Notifications
You must be signed in to change notification settings - Fork 252
8366125: [11u] Test compiler/loopopts/TestRangeCheckPredicatesControl.java fails OOM #3077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
@sendaoYan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 33 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
Looking for reviewer for this test bug fix. |
|
|
|
GHA report 29 jdi tests fails, the test log shows 'getaddrinfo: unknown host' cause jdi tests fails, this seems like environmental issue. it's unrelated to this PR. /approval request Increase max heap size for ZGC to avoid OOM during JVM starting. Test-fix, no risk. |
|
@sendaoYan |
|
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
Thanks for the reviews and approved. /integrate |
|
Going to push as commit 22942ef.
Your commit was automatically rebased without conflicts. |
|
@sendaoYan Pushed as commit 22942ef. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
On ours linux-x64 machine,
-Xmx256M -XX:+UnlockExperimentalVMOptions -XX:+UseZGCcan not start JVM because of OOM. I think it's not a JVM bug in jdk11u, I think we should increase the max heap size to make test run normally after JDK-8251949. The-Xmx256mwas introduced by JDK-8251949 only for jdk11u. So this PR will only for jdk11u also.Change has been verified locally, test-fix only, ro risk.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3077/head:pull/3077$ git checkout pull/3077Update a local copy of the PR:
$ git checkout pull/3077$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3077/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3077View PR using the GUI difftool:
$ git pr show -t 3077Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3077.diff
Using Webrev
Link to Webrev Comment