Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 26, 2025

Hi all,

On ours linux-x64 machine, -Xmx256M -XX:+UnlockExperimentalVMOptions -XX:+UseZGC can not start JVM because of OOM. I think it's not a JVM bug in jdk11u, I think we should increase the max heap size to make test run normally after JDK-8251949. The -Xmx256m was introduced by JDK-8251949 only for jdk11u. So this PR will only for jdk11u also.

Change has been verified locally, test-fix only, ro risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8366125 needs maintainer approval

Issue

  • JDK-8366125: [11u] Test compiler/loopopts/TestRangeCheckPredicatesControl.java fails OOM (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3077/head:pull/3077
$ git checkout pull/3077

Update a local copy of the PR:
$ git checkout pull/3077
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3077/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3077

View PR using the GUI difftool:
$ git pr show -t 3077

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3077.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 26, 2025

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8366125: [11u] Test compiler/loopopts/TestRangeCheckPredicatesControl.java fails OOM

Reviewed-by: phh, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 26, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 26, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Looking for reviewer for this test bug fix.

@openjdk
Copy link

openjdk bot commented Sep 26, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@sendaoYan
Copy link
Member Author

GHA report 29 jdi tests fails, the test log shows 'getaddrinfo: unknown host' cause jdi tests fails, this seems like environmental issue. it's unrelated to this PR.

/approval request Increase max heap size for ZGC to avoid OOM during JVM starting. Test-fix, no risk.

@openjdk
Copy link

openjdk bot commented Sep 27, 2025

@sendaoYan
8366125: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 27, 2025
@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Oct 21, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 19, 2025
@sendaoYan
Copy link
Member Author

Thanks for the reviews and approved.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

Going to push as commit 22942ef.
Since your change was applied there have been 33 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 19, 2025
@openjdk openjdk bot closed this Nov 19, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 19, 2025
@openjdk
Copy link

openjdk bot commented Nov 19, 2025

@sendaoYan Pushed as commit 22942ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8366125 branch November 19, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants