-
Notifications
You must be signed in to change notification settings - Fork 239
8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror" #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
@zhengyu123 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Could you review this redo patch? Thanks, -Zhengyu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@zhengyu123 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 70 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
I ran the change through our nightly tests an do not see any failures. |
SAP nightly tests all green now. |
Thanks, @GoeLin |
/integrate |
Going to push as commit 40d7d03.
Your commit was automatically rebased without conflicts. |
@zhengyu123 Pushed as commit 40d7d03. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This patch redoes JDK-8274338 backport to openjdk 11u.
Early backport failed and was backout. The failure was due to
CLD::loaded_classes_do()
, now requires to holdMultiArray_lock
, therefore, the closureLinkSharedClassesClosure
can not triggerJavaCall
while holding a lock.[Revised]
Drop new assertion in
CLD::loaded_classes_do()
, only addMultiArray_lock
toInstanceKlass::restore_unshareable_info()
, which is the only thing matter in this patch.Test:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/632/head:pull/632
$ git checkout pull/632
Update a local copy of the PR:
$ git checkout pull/632
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/632/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 632
View PR using the GUI difftool:
$ git pr show -t 632
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/632.diff