Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. #250

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link

@kvergizova kvergizova commented Aug 2, 2022

I'd like to backport JDK-8280684 to 15u for parity with 11u.
The patch doesn't apply cleanly due to copyright years and context difference in jfrJavaSupport.cpp, jfrJavaSupport.hpp and jfrStreamWriterHost.inline.hpp (JDK-8252685 and JDK-8183227 are not in 15u).
Additionally, similar to 11u backport, the original condition error_msg != NULL is left without replacing NULL with nullptr, because C++14 Language Features was enabled since jdk16 (JDK-8208089).

Tested with jdk/jfr and tier1.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/250/head:pull/250
$ git checkout pull/250

Update a local copy of the PR:
$ git checkout pull/250
$ git pull https://git.openjdk.org/jdk15u-dev pull/250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 250

View PR using the GUI difftool:
$ git pr show -t 250

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/250.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 2, 2022

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9471f24ca191832669a13e5a1ea73f7097a25927 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. Aug 2, 2022
@openjdk
Copy link

openjdk bot commented Aug 2, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 2, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 2, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 2, 2022

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e3c3e3d: 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 2, 2022
@kvergizova
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 2, 2022

Going to push as commit ed0200a.
Since your change was applied there has been 1 commit pushed to the master branch:

  • e3c3e3d: 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 2, 2022
@openjdk openjdk bot closed this Aug 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2022
@openjdk
Copy link

openjdk bot commented Aug 2, 2022

@kvergizova Pushed as commit ed0200a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants