This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device. #250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I'd like to backport JDK-8280684 to 15u for parity with 11u.
The patch doesn't apply cleanly due to copyright years and context difference in jfrJavaSupport.cpp, jfrJavaSupport.hpp and jfrStreamWriterHost.inline.hpp (JDK-8252685 and JDK-8183227 are not in 15u).
Additionally, similar to 11u backport, the original condition
error_msg != NULL
is left without replacing NULL with nullptr, because C++14 Language Features was enabled since jdk16 (JDK-8208089).Tested with jdk/jfr and tier1.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk15u-dev pull/250/head:pull/250
$ git checkout pull/250
Update a local copy of the PR:
$ git checkout pull/250
$ git pull https://git.openjdk.org/jdk15u-dev pull/250/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 250
View PR using the GUI difftool:
$ git pr show -t 250
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk15u-dev/pull/250.diff