8253954: javac crash when compiling code with enhanced switch expressions with option -Xjcov

[vicente-romero-oracle]

Please review this one liner patch that is fixing a crash in javac when compiling with option -Xjcov. The crash was due to an assertion failure at com.sun.tools.javac.jvm.CRTable as no position was found for compiler generated yield trees in some cases. The fix is to visit the value expression in the yield tree so that when the CRT table is being generated, the position for the yield tree is not null

TIA

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253954: javac crash when compiling code with enhanced switch expressions with option -Xjcov

Reviewers

• Jonathan Gibbons (@jonathan-gibbons - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk16 pull/66/head:pull/66
$ git checkout pull/66

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vicente-romero-oracle The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (deabc0f)

[jonathan-gibbons]

Looks OK to me

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253954: javac crash when compiling code with enhanced switch expressions with option -Xjcov

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vicente-romero-oracle]

/integrate

[openjdk]

@vicente-romero-oracle Since your change was applied there has been 1 commit pushed to the master branch:

• 8b37c2c: 8257468: runtime/whitebox/TestWBDeflateIdleMonitors.java fails with Monitor should be deflated.: expected true to equal false

Your commit was automatically rebased without conflicts.

Pushed as commit 23b83c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.