-
Notifications
You must be signed in to change notification settings - Fork 147
8268369: SIGSEGV in PhaseCFG::implicit_null_check due to missing null check #212
Conversation
👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into |
@TobiHartmann The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@TobiHartmann This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review, Christian! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
Thanks Vladimir! |
/integrate |
@TobiHartmann Pushed as commit 4ad8b04. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I've missed a null check with JDK-8266480,
ctrl
can beNULL
(the comment above even says so).Thanks,
Tobias
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/212/head:pull/212
$ git checkout pull/212
Update a local copy of the PR:
$ git checkout pull/212
$ git pull https://git.openjdk.java.net/jdk17 pull/212/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 212
View PR using the GUI difftool:
$ git pr show -t 212
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/212.diff