Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk17 Public archive

8271507: ProblemList SA tests that are failing with ZGC due to JDK-8248912 #294

Closed
wants to merge 1 commit into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Jul 29, 2021

These tests recently started failing frequently with ZGC


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8271507: ProblemList SA tests that are failing with ZGC due to JDK-8248912

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/294/head:pull/294
$ git checkout pull/294

Update a local copy of the PR:
$ git checkout pull/294
$ git pull https://git.openjdk.java.net/jdk17 pull/294/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 294

View PR using the GUI difftool:
$ git pr show -t 294

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/294.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2021

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 29, 2021
@openjdk
Copy link

openjdk bot commented Jul 29, 2021

@plummercj To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@plummercj
Copy link
Contributor Author

/label serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.java.net label Jul 29, 2021
@openjdk
Copy link

openjdk bot commented Jul 29, 2021

@plummercj
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 29, 2021

Webrevs

Comment on lines +44 to +46
serviceability/sa/TestJhsdbJstackMixed.java 8248912 generic-all
serviceability/sa/ClhsdbPstack.java#id0 8248912 generic-all
serviceability/sa/ClhsdbPstack.java#id1 8248912 generic-all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only seeing failures for 8248912 on linux-x64. You might
want to limit it to that platform.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered it, but given it's ZGC, and the SA support for it is not that stable, I thought it best just to silence it on all platforms.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a reasonable plan. Thumbs up.

@openjdk
Copy link

openjdk bot commented Jul 29, 2021

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271507: ProblemList SA tests that are failing with ZGC due to JDK-8248912

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 29, 2021
Comment on lines +44 to +46
serviceability/sa/TestJhsdbJstackMixed.java 8248912 generic-all
serviceability/sa/ClhsdbPstack.java#id0 8248912 generic-all
serviceability/sa/ClhsdbPstack.java#id1 8248912 generic-all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a reasonable plan. Thumbs up.

@dcubed-ojdk
Copy link
Member

Also, this is a trivial fix.

@plummercj
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 30, 2021

Going to push as commit a1b5b81.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 286d313: 8271489: (doc) Clarify Filter Factory example

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 30, 2021
@openjdk
Copy link

openjdk bot commented Jul 30, 2021

@plummercj Pushed as commit a1b5b81.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.java.net
Development

Successfully merging this pull request may close these issues.

2 participants