-
Notifications
You must be signed in to change notification settings - Fork 146
8271507: ProblemList SA tests that are failing with ZGC due to JDK-8248912 #294
Conversation
👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into |
@plummercj To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label serviceability |
@plummercj |
serviceability/sa/TestJhsdbJstackMixed.java 8248912 generic-all | ||
serviceability/sa/ClhsdbPstack.java#id0 8248912 generic-all | ||
serviceability/sa/ClhsdbPstack.java#id1 8248912 generic-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only seeing failures for 8248912 on linux-x64. You might
want to limit it to that platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered it, but given it's ZGC, and the SA support for it is not that stable, I thought it best just to silence it on all platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a reasonable plan. Thumbs up.
@plummercj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
serviceability/sa/TestJhsdbJstackMixed.java 8248912 generic-all | ||
serviceability/sa/ClhsdbPstack.java#id0 8248912 generic-all | ||
serviceability/sa/ClhsdbPstack.java#id1 8248912 generic-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a reasonable plan. Thumbs up.
Also, this is a trivial fix. |
/integrate |
@plummercj Pushed as commit a1b5b81. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
These tests recently started failing frequently with ZGC
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/294/head:pull/294
$ git checkout pull/294
Update a local copy of the PR:
$ git checkout pull/294
$ git pull https://git.openjdk.java.net/jdk17 pull/294/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 294
View PR using the GUI difftool:
$ git pr show -t 294
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/294.diff