Skip to content
This repository has been archived by the owner. It is now read-only.

JDK-8272639: jpackaged applications using microphone on mac #306

Closed
wants to merge 1 commit into from

Conversation

andyherrick
Copy link

@andyherrick andyherrick commented Sep 9, 2021

backport from jdk-18


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272639: jpackaged applications using microphone on mac ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/306/head:pull/306
$ git checkout pull/306

Update a local copy of the PR:
$ git checkout pull/306
$ git pull https://git.openjdk.java.net/jdk17 pull/306/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 306

View PR using the GUI difftool:
$ git pr show -t 306

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/306.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 9, 2021

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@andyherrick andyherrick marked this pull request as ready for review Sep 9, 2021
@openjdk openjdk bot added the rfr label Sep 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@andyherrick The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Sep 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 9, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272639: jpackaged applications using microphone on mac

Reviewed-by: almatvee, asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 9, 2021
@mrserb
Copy link
Member

@mrserb mrserb commented Sep 9, 2021

Is it for jdk17 or for jdk17u?

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 10, 2021

This must not be integrated into this repo.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Sep 10, 2021

See JDK-8273592 for an explanation as to why. There is no more content approved for JDK 17. This should go into openjdk/jdk17u.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core-libs ready rfr
5 participants