8307990: jspawnhelper must close its writing side of a pipe before reading from it

[simonis]

Backporting the jspwanhelper fixes from JDK-8307990 because we constantly see customers hitting this issue in production. For more details about the problem please refer to the corresponding release notes in https://bugs.openjdk.org/browse/JDK-8308297. The original change was pushed to JDK 21 in June so it had quite some time to mature.

The backport was not clean because of some trivial copyright changes and because JDK-8310265: (process) jspawnhelper should not use argv[0], which was done after this change, already got backported to JDK 17u before this change.

Once this backport will be reviewed and approved, I'll also plan to backport JDK-8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990 which was a follow-up fix for this change (and clean backport - see pr/2017).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8307990 needs maintainer approval

Issue

• JDK-8307990: jspawnhelper must close its writing side of a pipe before reading from it (Bug - P3 - Approved)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2013/head:pull/2013
$ git checkout pull/2013

Update a local copy of the PR:
$ git checkout pull/2013
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2013/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2013

View PR using the GUI difftool:
$ git pr show -t 2013

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2013.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back simonis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (0ea43b07)

[shipilev]

Seems the similar to the mainline patch: openjdk/jdk@39f6d80

[openjdk]

⚠️ @simonis This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[simonis]

/approval request This issue is a regression since JDK 13 which was only detected when more services started to move to JDK 17. It regularly happens in our production deployments. The original fix was integrated into JDK 21 in June which gave it enough testing and exposure.

[openjdk]

@simonis
8307990: The approval request has been created successfully.

[openjdk]

@simonis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307990: jspawnhelper must close its writing side of a pipe before reading from it

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• f8f733d: Merge
• b78a848: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[simonis]

/integrate

[openjdk]

Going to push as commit 16f319a.
Since your change was applied there have been 6 commits pushed to the master branch:

• 0bc91f6: 8313643: Update HarfBuzz to 8.2.2
• 450c201: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks
• 5025a97: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
• be72703: 8301306: java/net/httpclient/* fail with -Xcomp
• f8f733d: Merge
• b78a848: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all

Your commit was automatically rebased without conflicts.

[openjdk]

@simonis Pushed as commit 16f319a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.