8318562: Computational test more than 2x slower when AVX instructions are used

[sviswa7]

A small backport PR which fixes the performance regression with vcvt* instructions on AVX platforms.
Minor changes were required to resolve a conflict in macroAssembler_x86.cpp/hpp. The conflict was due to a change in locked_cmpxchgptr signature on mainline.

Please review.

Best Regards,
Sandhya

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8318562 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8318562: Computational test more than 2x slower when AVX instructions are used (Enhancement - P4 - Approved)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2016/head:pull/2016
$ git checkout pull/2016

Update a local copy of the PR:
$ git checkout pull/2016
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2016/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2016

View PR using the GUI difftool:
$ git pr show -t 2016

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2016.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[sviswa7]

/approval request A small backport PR which fixes the performance regression with vcvt* instructions on AVX platforms.,
Minor changes were required to resolve a conflict in macroAssembler_x86.cpp/hpp.,
The conflict was due to a change in locked_cmpxchgptr signature on mainline.,
Please approve.

[openjdk]

@sviswa7
8318562: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (8fb1cb70)

[sviswa7]

@vnkozlov @shipilev could you please help review this small backport to 17u-dev?

[shipilev]

Looks fine.

[openjdk]

⚠️ @sviswa7 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@sviswa7 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318562: Computational test more than 2x slower when AVX instructions are used

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

• 97d8ed2: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton
• 48c8478: 8320798: Console read line with zero out should zero out underlying buffer
• 5653d2d: 8320597: RSA signature verification fails on signed data that does not encode params correctly
• dcba538: 8283400: [macos] a11y : Screen magnifier does not reflect JRadioButton value change
• 5fe2d51: 8297968: Crash in PrintOptoAssembly
• 873148e: 8273454: C2: Transform (-a)(-b) into ab
• 969f105: 8302017: Allocate BadPaddingException only if it will be thrown
• 78839e9: 8054022: HttpURLConnection timeouts with Expect: 100-Continue and no chunking
• 6493102: 7167356: (javac) investigate failing tests in JavacParserTest
• 71471c1: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure
• ... and 69 more: https://git.openjdk.org/jdk17u-dev/compare/68f72954dca6166758d7da78628afa0aca2caf88...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[sviswa7]

Thanks a lot @shipilev for the review.

[sviswa7]

/integrate

[openjdk]

@sviswa7
Your change (at version 8fb1cb7) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 9a104e0.
Since your change was applied there have been 86 commits pushed to the master branch:

• 5ed1926: 8317507: C2 compilation fails with "Exceeded _node_regs array"
• 7973bfe: 8321215: Incorrect x86 instruction encoding for VSIB addressing mode
• c555fe3: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch
• 3809b71: 8293117: Add atomic bitset functions
• a032136: 8295068: SSLEngine throws NPE parsing CertificateRequests
• f033de0: 8274632: Possible pointer overflow in PretouchTask chunk claiming
• c44bd2b: 8320001: javac crashes while adding type annotations to the return type of a constructor
• 97d8ed2: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton
• 48c8478: 8320798: Console read line with zero out should zero out underlying buffer
• 5653d2d: 8320597: RSA signature verification fails on signed data that does not encode params correctly
• ... and 76 more: https://git.openjdk.org/jdk17u-dev/compare/68f72954dca6166758d7da78628afa0aca2caf88...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @sviswa7 Pushed as commit 9a104e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.