Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem #2057

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 18, 2023

I backport this to improve accessability in 17.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8311160 needs maintainer approval

Issue

  • JDK-8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2057/head:pull/2057
$ git checkout pull/2057

Update a local copy of the PR:
$ git checkout pull/2057
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2057/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2057

View PR using the GUI difftool:
$ git pr show -t 2057

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2057.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c1f4595e64b0ea0439c6e7f61a6a92b56b526d97 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem Dec 18, 2023
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 18, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 18, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 18, 2023

Webrevs

@openjdk openjdk bot added the approval label Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 20, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 9d2467b: 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory
  • a84f19f: 8263256: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails due to dynamic reconfigurations of network interface during test
  • 00d74be: 8314220: Configurable InlineCacheBuffer size
  • 9a104e0: 8318562: Computational test more than 2x slower when AVX instructions are used
  • 5ed1926: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • 7973bfe: 8321215: Incorrect x86 instruction encoding for VSIB addressing mode
  • c555fe3: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch
  • 3809b71: 8293117: Add atomic bitset functions
  • a032136: 8295068: SSLEngine throws NPE parsing CertificateRequests
  • f033de0: 8274632: Possible pointer overflow in PretouchTask chunk claiming
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/97d8ed2d1441210a3593029aaa0b278a58f31d34...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 20, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 21, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 21, 2023

Going to push as commit d82430b.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 7e086a2: 8313082: Enable CreateCoredumpOnCrash for testing in makefiles
  • 9d2467b: 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory
  • a84f19f: 8263256: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails due to dynamic reconfigurations of network interface during test
  • 00d74be: 8314220: Configurable InlineCacheBuffer size
  • 9a104e0: 8318562: Computational test more than 2x slower when AVX instructions are used
  • 5ed1926: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • 7973bfe: 8321215: Incorrect x86 instruction encoding for VSIB addressing mode
  • c555fe3: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch
  • 3809b71: 8293117: Add atomic bitset functions
  • a032136: 8295068: SSLEngine throws NPE parsing CertificateRequests
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/97d8ed2d1441210a3593029aaa0b278a58f31d34...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 21, 2023
@openjdk openjdk bot closed this Dec 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 21, 2023
@openjdk
Copy link

openjdk bot commented Dec 21, 2023

@GoeLin Pushed as commit d82430b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant