-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8272651: G1 heap region info print order changed by JDK-8269914 #2261
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
GHA failure: Well known Risk-V build issue. Unrelated. |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 158f91a.
Your commit was automatically rebased without conflicts. |
I backport this as prerequisite for 8291753 as proposed before in #1900.
The backport has been tested by releaseing it in SapMachine in 17.0.10. This patch here is identical to the one in SapMachine. It will go to 17.0.12 giving enough time to settle.
Also, this will bring G1 code of 17 closer to head probably simplifying further backports.
src/hotspot/share/gc/g1/g1CollectedHeap.cpp
Some lines removed are not in 17:
some later:
These are added again a bit further down.
As adding them would modify the behaviour, I only added
them uncommented.
test/hotspot/jtreg/gc/g1/TestEagerReclaimHumongousRegionsLog.java
The file already has the correct coding. Obviously these lines
were changed after 17 and later reverted again.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2261/head:pull/2261
$ git checkout pull/2261
Update a local copy of the PR:
$ git checkout pull/2261
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2261/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2261
View PR using the GUI difftool:
$ git pr show -t 2261
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2261.diff
Webrev
Link to Webrev Comment